Skip to content

[WPB-27953] SCIM: Make role field in user schema comply with RFC. - #5440

Merged
fisx merged 6 commits into
developfrom
WPB-27953-scim_-make-role-field-in-user-schema-comply-with-rfc
Aug 14, 2026
Merged

[WPB-27953] SCIM: Make role field in user schema comply with RFC.#5440
fisx merged 6 commits into
developfrom
WPB-27953-scim_-make-role-field-in-user-schema-comply-with-rfc

Conversation

@fisx

@fisx fisx commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Fixes #5435

This changes the "role" field in the User schema. The release notes contain a warning about this with instructions how to re-align code. If anybody is impacted by this change, they are in violation of the RFC as we were and should follow the release note instructions. To make things as backwards-compatible as can be, the new code parses both "member" and {"value": "member"} as a role.

https://wearezeta.atlassian.net/browse/WPB-27953

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 11, 2026
@fisx
fisx force-pushed the WPB-27953-scim_-make-role-field-in-user-schema-comply-with-rfc branch 2 times, most recently from 9bb9a16 to a234f5b Compare August 11, 2026 12:24
@fisx
fisx force-pushed the WPB-27953-scim_-make-role-field-in-user-schema-comply-with-rfc branch from a234f5b to acf9fd9 Compare August 11, 2026 12:35
@fisx
fisx marked this pull request as ready for review August 11, 2026 12:36
@fisx
fisx requested review from a team as code owners August 11, 2026 12:36
fisx added 4 commits August 11, 2026 16:44
hack: there is some untracktable issue about different ormolu versions
having different views on how to render "  f $\n    x", so we just
avoid it here.

@blackheaven blackheaven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits


-- This file is part of the Wire Server implementation.
--
-- Copyright (C) 2025 Wire Swiss GmbH <opensource@wire.com>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- Copyright (C) 2025 Wire Swiss GmbH <opensource@wire.com>
-- Copyright (C) 2026 Wire Swiss GmbH <opensource@wire.com>


-- This file is part of the Wire Server implementation.
--
-- Copyright (C) 2025 Wire Swiss GmbH <opensource@wire.com>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- Copyright (C) 2025 Wire Swiss GmbH <opensource@wire.com>
-- Copyright (C) 2026 Wire Swiss GmbH <opensource@wire.com>

@fisx
fisx merged commit 3f7930c into develop Aug 14, 2026
9 checks passed
@fisx
fisx deleted the WPB-27953-scim_-make-role-field-in-user-schema-comply-with-rfc branch August 14, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SCIM roles Attribute Returned as String Array Instead of Complex Objects

3 participants