Echidna testing and flat fee introduction - #312
Merged
Merged
Conversation
gakonst
reviewed
Sep 2, 2020
gakonst
approved these changes
Sep 2, 2020
gakonst
left a comment
gakonst
left a comment
Contributor
There was a problem hiding this comment.
LGTM - 2 minor comments, thanks for this. Super useful.
aniemerg
approved these changes
Sep 2, 2020
aniemerg
reviewed
Sep 2, 2020
| assert(daiOut <= daiIn); | ||
| } | ||
|
|
||
| function testLiquidityDaiOutForYDaiIn(uint128 daiReserves, uint128 yDAIReserves, uint128 yDaiIn, uint128 timeTillMaturity) |
Member
There was a problem hiding this comment.
Wait, even with the fee the invariant doesn't always grow?
danrobinson
reviewed
Sep 4, 2020
danrobinson
reviewed
Sep 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After echidna testing on trade and trade reversals, a precision of 64 bits for iterative arithmetic and a flat fee of 10**12 wei Dai on trades were imposed.