Skip to content

Conversation

@szb512
Copy link

@szb512 szb512 commented Mar 13, 2020

Updates Tcl/Tk to 3.8.10. Check issue 39107. I don't know if I have done it right, let me know if I need to make changes.

https://bugs.python.org/issue39107

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@szb512

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@terryjreedy terryjreedy changed the title (bpo-39107) Update Tcl/Tk (bpo-39107) Update Tcl/Tk on macOS Mar 13, 2020
@terryjreedy
Copy link
Member

The patch is trivial. What testing have you done with what macOS version(s)?

@szb512
Copy link
Author

szb512 commented Mar 13, 2020

Stability testing and performance testing

@ned-deily
Copy link
Member

Thanks for the PR but we are not ready yet to move to 8.6.10 for the python.org macOS installers, the only thing this code affects.

@szb512
Copy link
Author

szb512 commented Mar 13, 2020

Ok.

@szb512
Copy link
Author

szb512 commented Mar 14, 2020

Do you want me to update anything else?

@ned-deily
Copy link
Member

No need for you to do anything more on this, thanks. I will deal with it conjunction with some other necessary changes.

@szb512
Copy link
Author

szb512 commented Mar 17, 2020

Ok.

@szb512 szb512 requested a review from a team as a code owner March 19, 2020 15:13
@szb512 szb512 changed the title (bpo-39107) Update Tcl/Tk on macOS bpo-39107: Update Tcl/Tk on macOS AND Windows Mar 19, 2020
@szb512
Copy link
Author

szb512 commented Mar 19, 2020

Updated PR for the windows side.

@ned-deily
Copy link
Member

Please make the Windows changes a separate PR. Which Tk versions are used on Windows and macOS are independent issues.

@szb512
Copy link
Author

szb512 commented Mar 20, 2020 via email

@zware
Copy link
Member

zware commented Mar 20, 2020

@szb512 Thanks for your interest in contributing here, but unfortunately this is not a change that can really be contributed by anyone other than @ned-deily on the Mac side and @zooba on the Windows side: the changes to the Mac installer have to be hand-tested by @ned-deily as the macOS installer producer, and Tcl and Tk have to be built, signed and checked into a separate repository by @zooba as the Windows installer producer. As such, I think it's best that we just close this PR.

You could argue that we ought to have a more automated process here, but we currently don't :)

Thanks for trying, though, and I hope your next contribution goes more smoothly!

@zware zware closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants