-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
bpo-39107: Update Tcl/Tk on macOS AND Windows #18982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
The patch is trivial. What testing have you done with what macOS version(s)? |
|
Stability testing and performance testing |
|
Thanks for the PR but we are not ready yet to move to 8.6.10 for the python.org macOS installers, the only thing this code affects. |
|
Ok. |
Prepare for Tk changes
|
Do you want me to update anything else? |
|
No need for you to do anything more on this, thanks. I will deal with it conjunction with some other necessary changes. |
|
Ok. |
More in issue 39107.
Update tcl-tk for windows
|
Updated PR for the windows side. |
|
Please make the Windows changes a separate PR. Which Tk versions are used on Windows and macOS are independent issues. |
|
I actually don’t know how to…
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10
…________________________________
From: Ned Deily <[email protected]>
Sent: Friday, March 20, 2020 4:37:32 AM
To: python/cpython <[email protected]>
Cc: szb512 <[email protected]>; Mention <[email protected]>
Subject: Re: [python/cpython] [bpo-39107](https://bugs.python.org/issue39107): Update Tcl/Tk on macOS AND Windows (#18982)
Please make the Windows changes a separate PR. Which Tk versions are used on Windows and macOS are independent issues.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#18982 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALLIPBZYILQ7OHRZ6CTEPATRIMTMZANCNFSM4LHPZJBQ>.
|
|
@szb512 Thanks for your interest in contributing here, but unfortunately this is not a change that can really be contributed by anyone other than @ned-deily on the Mac side and @zooba on the Windows side: the changes to the Mac installer have to be hand-tested by @ned-deily as the macOS installer producer, and Tcl and Tk have to be built, signed and checked into a separate repository by @zooba as the Windows installer producer. As such, I think it's best that we just close this PR. You could argue that we ought to have a more automated process here, but we currently don't :) Thanks for trying, though, and I hope your next contribution goes more smoothly! |
Updates Tcl/Tk to 3.8.10. Check issue 39107. I don't know if I have done it right, let me know if I need to make changes.
https://bugs.python.org/issue39107