Skip to content

bpo-40246: Report a different error message for invalid string prefixes #19476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 2 commits into from
Apr 12, 2020
Merged

bpo-40246: Report a different error message for invalid string prefixes #19476

pablogsal merged 2 commits into from
Apr 12, 2020

Conversation

@lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Apr 11, 2020 •
edited by bedevere-bot
Loading

@lysnikolaou
Copy link
Member Author

lysnikolaou commented Apr 11, 2020

CC: @pablogsal @gvanrossum

gvanrossum
gvanrossum approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One other core dev please?

pablogsal
pablogsal approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit 41d5b94 into python:master Apr 12, 2020
@pablogsal
Copy link
Member

pablogsal commented Apr 12, 2020

Great job @lysnikolaou 🎉

@lysnikolaou lysnikolaou mentioned this pull request Apr 12, 2020
Closed
@lysnikolaou lysnikolaou mentioned this pull request May 3, 2020
Merged
@lysnikolaou lysnikolaou deleted the string-prefix branch May 8, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lysnikolaou @pablogsal @gvanrossum @the-knights-who-say-ni @bedevere-bot