[3.7] bpo-31333: Re-implement ABCMeta in C (GH-5273) #5733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds C versions of methods used by ABCMeta that improve performance of various ABC operations.
gvanrossum
approved these changes
Feb 18, 2018
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
This is only a formality for the backport right?
Member
Author
I think so, @ned-deily gave us an extension to beta2, I just wanted to make him aware that this is ready. Or can I just proceed now? (I added him as a reviewer here so he should get a notification.) |
Member
|
I'm just running some smoke tests now. |
ned-deily
approved these changes
Feb 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue31333