Skip to content

Conversation

@1st1
Copy link
Member

@1st1 1st1 commented May 23, 2018

@1st1
Copy link
Member Author

1st1 commented May 23, 2018

@elprans please take a look.

@1st1 1st1 removed the request for review from asvetlov May 23, 2018 16:01
Any positional arguments after the callback will be passed to the
callback when it is called.

An optional keyword-only *context* parameter allows to specify a custom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The optional context keyword-only argument

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix paremeter to argument

is called. If you want the callback to be called with some named
arguments, use a closure or :func:`functools.partial`.

An optional keyword-only *context* parameter allows to specify a custom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The optional context keyword-only argument

future is already done when this is called, the callback is scheduled
with :meth:`~AbstractEventLoop.call_soon`.

An optional keyword-only *context* parameter allows to specify a custom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The optional context keyword-only argument

destroying the event loop.
(Contributed by Yury Selivanov in :issue:`32314`.)

* asyncio gains support for :mod:`contextvars`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/gains/gained/

@1st1 1st1 merged commit 28b9178 into python:master May 23, 2018
@miss-islington
Copy link
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@1st1 1st1 deleted the a567d branch May 23, 2018 17:35
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2018
(cherry picked from commit 28b9178)

Co-authored-by: Yury Selivanov <[email protected]>
@bedevere-bot
Copy link

GH-7077 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 23, 2018
(cherry picked from commit 28b9178)

Co-authored-by: Yury Selivanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants