Repository navigation
fix: runInTerminal misses config listeners - #345318
Merged
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Anthony Kim (@anthonykim1)Matched files:
|
Dmitriy Vasyura (dmitrivMS)
approved these changes
Oct 31, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the terminal tool metadata refresh triggered by approval-setting changes.
No open issues 🎉
What changed in this PR
Fixes stale run_in_terminal tool metadata after approval settings change, following the default-permission hardening in #345307.
Changes:
- Refreshes tool registration when default permission, global auto-approval, or terminal auto-approval settings change.
- Adds regression tests for elevation guidance when approval settings are enabled and disabled, including workspace-sourced change events.
| File | Description |
|---|---|
src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts |
Tests elevation-guidance refresh across approval-setting changes. |
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/terminal.chatAgentTools.contribution.ts |
Adds approval settings to the tool-registration refresh listener. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #345307
CC Anthony Kim (@anthonykim1).