Poisson distribution using cuRAND and STL #6096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greptile OverviewGreptile SummaryThis PR adds Poisson distribution support using
The implementation acknowledges that CPU and GPU variants produce different results due to different underlying algorithms. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Test as Test Code
participant Philox as Philox4x32_10
participant PoissonDist as poisson_dist
participant CurandGen as CurandGenerator
participant cuRAND as curand_poisson
participant StdLib as std::poisson_distribution
Note over Test,StdLib: GPU Path
Test->>Philox: init(seed, seq, offset)
Test->>CurandGen: CurandGenerator(curand_state)
Test->>PoissonDist: operator()(CurandGenerator)
PoissonDist->>CurandGen: Access state
PoissonDist->>cuRAND: curand_poisson(&state, mean)
cuRAND-->>PoissonDist: uint32_t value
PoissonDist-->>Test: uint32_t value
Note over Test,StdLib: CPU Path
Test->>Philox: init(seed, seq, offset)
Test->>PoissonDist: operator()(Philox)
PoissonDist->>StdLib: std::poisson_distribution(mean)(rng)
StdLib->>Philox: operator()() [multiple calls]
Philox-->>StdLib: uint32_t random values
StdLib-->>PoissonDist: uint32_t value
PoissonDist-->>Test: uint32_t value
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Signed-off-by: Michał Zientkiewicz <[email protected]>
Signed-off-by: Michał Zientkiewicz <[email protected]>
Signed-off-by: Michał Zientkiewicz <[email protected]>
Signed-off-by: Michal Zientkiewicz <[email protected]>
Signed-off-by: Michal Zientkiewicz <[email protected]>
Signed-off-by: Michal Zientkiewicz <[email protected]>
mzient
force-pushed
the
poisson_dist_curand_std
branch
from
51d34e0 to
e475f07
Compare
mzient
commented
Nov 25, 2025
Comment on lines
-27
to
-34
| template <typename CurandState> | ||
| struct CurandGenerator { | ||
| CurandState &state; | ||
| __device__ explicit CurandGenerator(CurandState &s) : state(s) {} | ||
| __device__ inline uint32_t operator()() const { | ||
| return curand(&state); | ||
| } | ||
| }; |
mzient
commented
Nov 25, 2025
| } | ||
| } | ||
|
|
||
| namespace { |
Contributor
Author
There was a problem hiding this comment.
Moved to a header file.
Signed-off-by: Michal Zientkiewicz <[email protected]>
Signed-off-by: Michal Zientkiewicz <[email protected]>
Signed-off-by: Michal Zientkiewicz <[email protected]>
mzient
commented
Nov 25, 2025
| namespace dali { | ||
| namespace random { | ||
|
|
||
| template <typename CurandState> |
Contributor
Author
There was a problem hiding this comment.
Moved here from the tests. It'll be useful in production code.
Collaborator
|
CI MESSAGE: [39149793]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [39149793]: BUILD FAILED |
rostan-t
approved these changes
Nov 26, 2025
jantonguirao
approved these changes
Nov 26, 2025
mdabek-nvidia
pushed a commit
to mdabek-nvidia/DALI
that referenced
this pull request
Nov 27, 2025
The distribution carries only the mean value and the actual distribution is selected a evaluation time. The results are not consistent between CPU and GPU. --------- Signed-off-by: Michal Zientkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
This PR adds Poisson distribution implemented with cuRAND for GPU and
std::poisson_distributionfor CPU.The tests cover distribution histograms.
There's also significant refactoring of the random distribution tests.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A