Fix reference to ob_type in unionobject.c and ceval

[nascheme]

BPO	42099
Nosy	@nascheme, @vstinner, @markshannon
PRs	bpo-42099: Fix reference to ob_type in unionobject.c and ceval #22829

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/vstinner'
closed_at = <Date 2020-10-27.19:01:50.886>
created_at = <Date 2020-10-20.19:18:59.370>
labels = ['interpreter-core', 'type-feature']
title = 'Fix reference to ob_type in unionobject.c and ceval'
updated_at = <Date 2020-10-27.19:01:50.886>
user = 'https://github.com/nascheme'

bugs.python.org fields:

activity = <Date 2020-10-27.19:01:50.886>
actor = 'Mark.Shannon'
assignee = 'vstinner'
closed = True
closed_date = <Date 2020-10-27.19:01:50.886>
closer = 'Mark.Shannon'
components = ['Interpreter Core']
creation = <Date 2020-10-20.19:18:59.370>
creator = 'nascheme'
dependencies = []
files = []
hgrepos = []
issue_num = 42099
keywords = ['patch']
message_count = 3.0
messages = ['379155', '379793', '379794']
nosy_count = 3.0
nosy_names = ['nascheme', 'vstinner', 'Mark.Shannon']
pr_nums = ['22829']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue42099'
versions = []

[nascheme]

It is great that access to ob_type has been cleaned up to use an access macro. There are two spots that still need fixing.

I think we should do something to help avoid this kind of thing slipping into the code in the future. E.g. a special build flag that renames the ob_type member would work. I'll make a separate bug for that.

[markshannon]

New changeset 0564aaf by Neil Schemenauer in branch 'master':
bpo-42099: Fix reference to ob_type in unionobject.c and ceval (GH-22829)
0564aaf

[markshannon]

Thanks Neil