test_importlib failure due to missing skip() method

[nascheme]

BPO	43288
Nosy	@nascheme, @miss-islington
PRs	bpo-43288: Fix test_importlib test to correctly skip #24612 [3.9] bpo-43288: Fix bug in test_importlib test. (GH-24612) #24613 Fix failed merge of bpo-43288. #24614 [3.9] bpo-43288: Fix bug in test_importlib test. #24616

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/nascheme'
closed_at = <Date 2021-03-03.00:47:15.522>
created_at = <Date 2021-02-21.19:04:37.593>
labels = ['type-bug', 'tests', '3.9', '3.10']
title = 'test_importlib failure due to missing skip() method'
updated_at = <Date 2021-03-03.00:47:15.521>
user = 'https://github.com/nascheme'

bugs.python.org fields:

activity = <Date 2021-03-03.00:47:15.521>
actor = 'orsenthil'
assignee = 'nascheme'
closed = True
closed_date = <Date 2021-03-03.00:47:15.522>
closer = 'orsenthil'
components = ['Tests']
creation = <Date 2021-02-21.19:04:37.593>
creator = 'nascheme'
dependencies = []
files = []
hgrepos = []
issue_num = 43288
keywords = ['patch']
message_count = 4.0
messages = ['387471', '387473', '387475', '387479']
nosy_count = 2.0
nosy_names = ['nascheme', 'miss-islington']
pr_nums = ['24612', '24613', '24614', '24616']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue43288'
versions = ['Python 3.9', 'Python 3.10']

[nascheme]

The FileSystem class is missing a skip() method. If the file system doesn't support Unicode filenames, the test crashes.

File "/home/nas/src/cpython/Lib/test/test_importlib/fixtures.py", line 221, in unicode_filename
self.skip("File system does not support non-ascii.")
AttributeError: 'FileSystem' object has no attribute 'skip'

I'm running tests inside a Debian 32-bit container and for some reason the test.support.FS_NONASCII variable is not set.

[nascheme]

New changeset 50288aa by Neil Schemenauer in branch 'master':
bpo-43288: Fix bug in test_importlib test. (GH-24612)
50288aa

[nascheme]

New changeset 84f7afe by Neil Schemenauer in branch 'master':
Fix failed merge of bpo-43288. (GH-24614)
84f7afe

[nascheme]

New changeset 44fe320 by Neil Schemenauer in branch '3.9':
[3.9] bpo-43288: Fix bug in test_importlib test. (GH-24616)
44fe320