Skip to content

fix border-radius on radio-switch #38884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julien-deramond merged 11 commits into from
Sep 14, 2023
Merged

fix border-radius on radio-switch #38884

julien-deramond merged 11 commits into from
Sep 14, 2023

Conversation

@jonnysp
Copy link
Contributor

@jonnysp jonnysp commented Jul 10, 2023 •
edited by julien-deramond
Loading

Description

add radio-switch sample and fix border-radius on radio-switch when roundet disabled

Screenshot 2023-07-10 083144

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@jonnysp jonnysp requested a review from a team as a code owner July 10, 2023 07:59
julien-deramond
julien-deramond reviewed Jul 10, 2023
View reviewed changes
julien-deramond
julien-deramond reviewed Jul 10, 2023
View reviewed changes
julien-deramond
julien-deramond reviewed Jul 10, 2023
View reviewed changes
julien-deramond
julien-deramond approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@XhmikosR XhmikosR requested a review from mdo July 18, 2023 15:04
@julien-deramond julien-deramond merged commit 9e5e22a into twbs:main Sep 14, 2023
@jonnysp
Copy link
Contributor Author

jonnysp commented Sep 15, 2023

👍

@jonnysp jonnysp deleted the fix-radio-switch-when-roundet-disable branch September 15, 2023 05:40
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@jonnysp @julien-deramond @romankupchak93
Fix border-radius of some switch variants when rounded is disabled (t…
c0b0689 
…wbs#38884)

Co-authored-by: Julien Déramond <[email protected]>
@damian-snyk damian-snyk mentioned this pull request Apr 19, 2024
Open
@CGrabda CGrabda mentioned this pull request May 17, 2024
Merged
@RatanaSenpai RatanaSenpai mentioned this pull request May 18, 2024
Open
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 19, 2024
Open
This was referenced May 19, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Sep 29, 2024
Open
@DeFiTON DeFiTON mentioned this pull request Sep 30, 2024
Open
@lisagorewitdecker lisagorewitdecker mentioned this pull request Sep 30, 2024
Merged
@YnnusAsamal YnnusAsamal mentioned this pull request Sep 30, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Sep 30, 2024
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 1, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 1, 2024
Open
@Akhamesra Akhamesra mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 2, 2024
Open
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 3, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 4, 2024
Open
@jtprogru jtprogru mentioned this pull request Oct 5, 2024
Open
@Gutts-n Gutts-n mentioned this pull request Oct 5, 2024
Open
@Kimahari Kimahari mentioned this pull request Oct 5, 2024
Merged
This was referenced Oct 5, 2024
Open
Open
This was referenced Oct 12, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 13, 2024
Open
This was referenced Oct 15, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 20, 2024
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 22, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 27, 2024
Open
This was referenced Oct 29, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Nov 3, 2024
Open
@Arrhenius09 Arrhenius09 mentioned this pull request Nov 6, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickhlauke patrickhlauke patrickhlauke left review comments

@julien-deramond julien-deramond julien-deramond approved these changes

@mdo mdo Awaiting requested review from mdo

Assignees

No one assigned

Labels

css v5

Projects

No open projects
v5.3.3
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonnysp @patrickhlauke @julien-deramond @XhmikosR