Skip to content

Conversation

@julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jul 11, 2023

Description

This PR adds target="_blank" and rel="noopener" to all external links in the documentation.

Note that subdomains of getbootstrap.com are considered internal links and are not affected by this change (like in the header).

Motivation & Context

External links are already using target="_blank" and rel="noopener" in the header for external links. This PR does the same thing for the footer for consistency and UX reasons.

Type of changes

  • Enhancement (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@mdo mdo merged commit 674ea99 into main Jul 17, 2023
@mdo mdo deleted the main-jd-add-target-blank-and-rel-noopener-to-footer-links branch July 17, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants