Skip to content

Conversation

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 19, 2024

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues


TODO:

  • Fix toggler in examples

@XhmikosR XhmikosR force-pushed the xmr/theme-toggler branch 2 times, most recently from 52fa751 to e329f60 Compare March 19, 2024 16:14
@XhmikosR XhmikosR marked this pull request as ready for review March 19, 2024 16:18
z-index: 1500;
}

.bd-mode-toggle .bi {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to move all this inline CSS to an external file and inline it after processing it through Sass. That's for later, though.

@julien-deramond julien-deramond self-requested a review March 20, 2024 16:42
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor modification in comment. The rest LGTM. It's a good idea to make this theme toggler a partial.

@XhmikosR XhmikosR merged commit d1636a7 into main Mar 20, 2024
@XhmikosR XhmikosR deleted the xmr/theme-toggler branch March 20, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants