Skip to content

Conversation

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented May 2, 2024

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@XhmikosR XhmikosR added the docs label May 2, 2024
@XhmikosR XhmikosR force-pushed the xmr/docs-sitemap branch from e4314ea to 0391caf Compare May 2, 2024 06:01
@XhmikosR XhmikosR marked this pull request as ready for review May 2, 2024 06:05
@julien-deramond julien-deramond self-requested a review May 2, 2024 07:08
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've compared the generated sitemap.xml from main and this branch.
All the URLs are the same, meaning that the disable attribute works well.

The only differences are in the formatting and are not at all important; things like:

-  </url><url>
+  </url>
+  <url>

and

-<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"
-xmlns:xhtml="http://www.w3.org/1999/xhtml">
+<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:xhtml="http://www.w3.org/1999/xhtml">

@XhmikosR XhmikosR merged commit 72d3b6e into main May 2, 2024
@XhmikosR XhmikosR deleted the xmr/docs-sitemap branch May 2, 2024 07:19
aisteur added a commit to aisteur/bootstrap that referenced this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants