Use different command to convert images with ImageMagick - #1480
Conversation
david-yz-liu
left a comment
There was a problem hiding this comment.
@ethanliu24 great work, and in particular the research for fixing the text-anchor value.
david-yz-liu
left a comment
There was a problem hiding this comment.
@ethanliu24 oops, there is one thing I forgot to flag for you. Currently there's a check on the server code that the convert executable is installed. This should also be changed to magick. Look at the Haskell setup files for the place I'm referring to.
79ff283 to
f3afc29
Compare
8633b1f to
a77ed93
Compare
2d9f5ca to
6e27cc8
Compare
|
|
||
| corepack enable | ||
| corepack prepare yarn@stable --activate | ||
|
|
| stack build hlint | ||
| yarn install | ||
|
|
||
There was a problem hiding this comment.
revert the changes on this line (GitHub is highlighting trailing whitespace here; I recommend configuring your text editor to automatically strip trailing whitespace)
| - run: | ||
| name: Install Package Dependencies | ||
| command: | | ||
| sudo apt-get update |
There was a problem hiding this comment.
keep this line (put the sudo apt-get install command immediately below it)
There was a problem hiding this comment.
I meant the existing command that installed texlive-latex-base (just running sudo apt-get install without additional arguments doesn't do much)
There was a problem hiding this comment.
I'm not too familiar with linux (yet), but is there a reason for installing latex first before imagemagick?
david-yz-liu
left a comment
There was a problem hiding this comment.
@ethanliu24 good work! LaTeX didn't need to be installed imagemagick (it could be installed afterwards), and my comments were about keeping the apt-get commands together, rather than separated.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
In recent versions of ImageMagick, the
convertcommand is deprecated, and it is recommended to use themagickcommand. This PR uses the recommended command to convert graphs to display in the export modal....
Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)