Introducing a Route to access the POST codes - #1603
Merged
david-yz-liu merged 3 commits intoSep 14, 2025
Merged
Conversation
…t did not work when looking at something from the front end)
Pull Request Test Coverage Report for Build 43f2157c-600e-448a-8180-35c69b493c08Details
💛 - Coveralls |
david-yz-liu
left a comment
Contributor
There was a problem hiding this comment.
@matt-dahlgren nice work, I just left a few minor comments
| - Added test cases for the `ExportModal` component in `js/components/common` | ||
| - Updated backend tests to use `tasty-discover` | ||
| - Added documentation for running a subset of the backend tests | ||
| - Added a route to access all POST codes stored in the database with test coverage |
Contributor
There was a problem hiding this comment.
This is an enhancement
| import Test.Tasty.HUnit (assertEqual, testCase) | ||
| import TestHelpers (clearDatabase, runServerPart, withDatabase) | ||
|
|
||
| -- | List of test cases as (label, input courses, expected output) |
Contributor
There was a problem hiding this comment.
All of the comments in this file need to be updated (they refer to courses, not programs)
david-yz-liu
approved these changes
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Added the module
Program.hsinapp/Controllers/to query the database to get a full list of POST codes in the database.Added tests to simulate calls to an empty and populated (single entry and multiple entries) database.
...
Details
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)