Skip to content

Issue/3155: Fix capybara link warning - #3196

Merged
CloCkWeRX merged 7 commits into
Growstuff:devfrom
italopires:fix-warning-link-capybara
Dec 18, 2022
Merged

Issue/3155: Fix capybara link warning#3196
CloCkWeRX merged 7 commits into
Growstuff:devfrom
italopires:fix-warning-link-capybara

Conversation

@italopires

@italopires italopires commented Dec 10, 2022

Copy link
Copy Markdown
Contributor

Changes Proposed in this Pull Request:

  • fix warning for have_link matcher: for selector :link must be an instance of String or Symbol. This will raise an error in a future version of Capybara. Called from

Fixes #3155

@italopires italopires changed the title Issue/3155: Fix warning link capybara Issue/3155: Fix capybara link warning Dec 11, 2022
@cesy

cesy commented Dec 12, 2022

Copy link
Copy Markdown
Member

Can you add yourself to our contributors list, please? One of the automated checks looks for that to make sure we give credit to everyone. Welcome to the project! And thanks for helping out with this.

@italopires

Copy link
Copy Markdown
Contributor Author

Can you add yourself to our contributors list, please? One of the automated checks looks for that to make sure we give credit to everyone. Welcome to the project! And thanks for helping out with this.

Done. It's a pleasure to contribute with Growstuff, thank you!!

@cesy

@CloCkWeRX

Copy link
Copy Markdown
Collaborator

This seems safe to merge, as it's specs only.

@CloCkWeRX
CloCkWeRX merged commit 13b99b4 into Growstuff:dev Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

selector :link must be an instance of String or Symbol. This will raise an error in a future version of Capybara.

4 participants