Skip to content

A bunch of minor fixes - #4

Merged
MHordecki merged 7 commits into
MHordecki:masterfrom
emberian:master
Jan 30, 2017
Merged

A bunch of minor fixes#4
MHordecki merged 7 commits into
MHordecki:masterfrom
emberian:master

Conversation

@emberian

@emberian emberian commented Feb 3, 2016

Copy link
Copy Markdown
Contributor

See commit messages.

Please release a new version to pypi after merging :)

This prevents package-internal imports from parser conflicting with any
user-defined module named parser, which is quite frequent when writing
parsers.

This feature is available since Python 2.5, per PEP 0328.
This is for python3 compat. basestring no longer exists in python3.
These clutter up otherwise empty output for users.
This is a "new" feature in PLY, where single-character tokens can be specified
directly by value instead of going through a name. For example, if in the
lexer there is:

    literals = ",.()[]{}"

then rules in the grammar can have, for example:

    expr : '(' {expr} ')'
@MHordecki

Copy link
Copy Markdown
Owner

LGTM, see the comments about the warnings suppression.

@emberian

emberian commented Feb 6, 2016

Copy link
Copy Markdown
Contributor Author

Note: added another commit with a feature: support for empty rules.

@MHordecki

Copy link
Copy Markdown
Owner

Oh man, totally forgot about submitting these.

@MHordecki
MHordecki merged commit 74568e0 into MHordecki:master Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants