Add createReducer - #10
Merged
Merged
Conversation
Contributor
|
An interesting side-effect of |
LPGhatguy
self-requested a review
March 3, 2018 23:31
Contributor
Author
|
Redux has an API requirement that actions have a It might be helpful to throw an error in |
Contributor
|
Oh wow, I didn't realize that or notice it the last time I skimmed the documentation. Cool! That check can come in a later PR if you're up for it, that would be a nice lint to have especially with middleware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #7.
It adds a
createReducerfunction that works effectively identically to the redux-create-reducer library. Example usage (taken from the tests):The first argument is
initialState, which will be returned if and only if the state provided to the reducer isnil. The second argument is a map of action types to reducer functions; the reducer corresponding to the action type will be used. If the action type is not in the map, the composite reducer will return the same value ofstatethat it received.