feat: add distortion effect - #743
Merged
Merged
Conversation
setoelkahfi
marked this pull request as ready for review
June 1, 2025 17:30
yara-blue
reviewed
Jun 1, 2025
Member
There was a problem hiding this comment.
nice example! its great to have more stuff showing how to use periodic_access!
yara-blue
reviewed
Jun 1, 2025
yara-blue
reviewed
Jun 1, 2025
| self.input.next().map(|value| { | ||
| let v = value * self.gain; | ||
| let t = self.threshold; | ||
| if v > t { |
Member
There was a problem hiding this comment.
actually the if/else if/else here can be replaced by f32::clamp right? Might be a little cleaner (and maybe that gets optimized in the future)
yara-blue
requested changes
Jun 1, 2025
yara-blue
left a comment
yara-blue
left a comment
Member
There was a problem hiding this comment.
Lets change the if/else if/else to a f32::clamp and then we are good to merge!
yara-blue
approved these changes
Jun 3, 2025
Member
|
Looks great! just one more thing and we can merge. This deserves a changelog entry! 🥳 🎈 |
Member
|
thanks! merged into 0.21 instead of master, fixed that with some manual gitting |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a simple distortion effect to the source.
Run examples: