Cover Block: Check for previously uploaded media before setting the dimRatio - #55422
Merged
Conversation
apeatling
added
[Type] Bug
|
Size Change: +6 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Oct 18, 2023
ramonjd
left a comment
ramonjd
left a comment
Member
There was a problem hiding this comment.
LGTM
Can't find any regressions, and the dim ratio of 100 persists across image changes.
Before
2023-10-18.13.49.35.mp4
After
2023-10-18.13.52.37.mp4
ockham
added a commit
that referenced
this pull request
Feb 12, 2026
…ages Add a test that verifies the fix from PR #55422 / issue #52835: when a user explicitly sets the overlay opacity (dimRatio) to 100 and then replaces the cover image via the toolbar, the dimRatio should remain at 100 rather than being reset to 50. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52835
What?
Stop resetting the
dimRatioto 50 when background media has previously been set and thedimRatiois 100.Why?
It's possible to use the overlay gradient color opacity settings on a cover block instead of using overlay opacity. In this scenario a user would set the overlay opacity to 100. By doing this when a new image is set, the overlay opacity is always reset to 50 rather than staying at a user set 100.
How?
Check for
originalUrlwhen deciding whether or not to reset thedimRatioto 50 when it was previously 100. This means that when a user sets the background media for the first time, it will still set a 50dimRatio.Testing Instructions
Screenshots or screencast
before.mp4
after.mp4