@wordpress/ui: Add global CSS defense module - #76783
Conversation
|
Size Change: +2.31 kB (+0.03%) Total Size: 7.74 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 9fbaf30. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23952899915
|
ciampo
left a comment
There was a problem hiding this comment.
This is clever! And it makes me want to setup visual regression for all storybook examples that compares with vs without global CSS to make sure all relevant properties are "guarded".
A few more questions:
- should we also prioritize working on t the proposed solution ? The sooner it's merged, the sooner it will propagate (hopefully for 7.3 or 7.4?)
- can we meaningfully make sure that, while the core solution hasn't been applied and propagated yet, our defense module stays in sync with any changes to the global styles?
| p.p { | ||
| font-size: var(--_gcd-p-font-size, 13px); | ||
| line-height: var(--_gcd-p-line-height, 1.5); | ||
| margin: var(--_gcd-p-margin, 1em 0); |
There was a problem hiding this comment.
Should the default margin here be also 0? It feels like a healthier default to delegate spacing to parent layout components, especially for components like Text. It would also be consistent with --_gcd-heading-margin
There was a problem hiding this comment.
So would you say that the Text component should set margin: 0? It currently doesn't, so will have UA margins when rendered as p or h* (existing behavior unrelated to this defense file).
p is a bit of a tough call because I can imagine a lot of multi-paragraph Text. Like maybe there should be a default vertical margin. .text + p.text selectors for margin-top on consecutive paragraphs? Maybe even a similar setup for .text + :is(h1, h2, h3, h4, h5, h6).text. An alternative may be to nudge people towards Stack.
@WordPress/gutenberg-design Do we have any specs on how vertical margins should be in body copy, between headings and paragraphs? We don't cover them in the typography tokens doc.
There was a problem hiding this comment.
I agree it's tough, but I believe that the cleanest configuration for better composition is not to have any margin on the individual components, and to resort to components like Stack (or custom styling` for vertical spacing.
Adding margin on Text would create inconsistency with other components that don't come with any margin, and would add some friction to composing components togetther
There was a problem hiding this comment.
and would add some friction to composing components togetther
This has come up a few times, and I agree with keeping these components unopinionated about spacing. Text should focus on typography, not layout.
The trade-off is that it leaves room for inconsistent spacing between consecutive paragraphs, but that risk exists anyway; whether Text has a margin or not consumers can still compose it with Stack and choose any gap they like to fudge the spacing.
Text + Stack feels like a solid foundation. From there, I suppose it becomes more of an ergonomics question: how do we guide consumers toward consistent composition?
As a next layer, we could introduce something like a TextBlock component to encode paragraph spacing. But then there's the question of headings + paragraphs... The gap between a h1 and a paragraph might be different to the gap between a h4 and a paragraph. A heading following a paragraph might benefit from a top margin. And then there's the question of how to space consecutive TextBlocks 😅
Maybe it's something better left to linting and documentation? Or maybe it's not a huge issue... large bodies of text in UI are relatively rare...
There was a problem hiding this comment.
Thanks for the discussion here. I split out the margin removal to #76970, as this can potentially be a breaking change for consumers who may have been (probably unintentionally) relying on UA margin.
Right, sooner is always better than later. But I actually have a lower sense of urgency now that we can see the full extent of this defense solution. It isn't as awful as I expected. Let's aim to get it in WP 7.1 though.
The "safety profile" is no different than it was before with |
ciampo
left a comment
There was a problem hiding this comment.
LGTM 🚀
Can be merged once rebased to include Text margin changes and remaining feedback is addressed.
should we also prioritize working on t the proposed solution ? The sooner it's merged, the sooner it will propagate (hopefully for 7.3 or 7.4?)
Right, sooner is always better than later. But I actually have a lower sense of urgency now that we can see the full extent of this defense solution. It isn't as awful as I expected. Let's aim to get it in WP 7.1 though.
👌 Sounds good. Merging this PR early in the 7.1 lifecycle should give us the necessary time.
can we meaningfully make sure that, while the core solution hasn't been applied and propagated yet, our defense module stays in sync with any changes to the global styles?
The "safety profile" is no different than it was before with
@wordpress/components. We could potentially set up some kind of mechanism where we are alerted when the upstream styles change, but not yet sure if something like that will be worth the trouble, especially considering signal/noise ratio. It wasn't all that necessary during our several years looking after@wordpress/components.
Visual regression could definitely help here :daydreaming:
| - `Dialog.Root`: expose `disablePointerDismissal` prop ([#76847](https://github.com/WordPress/gutenberg/pull/76847)). | ||
| - `Dialog.Popup`: Default `initialFocus` now deprioritizes the close icon, focusing the first tabbable content element instead (following WAI-ARIA APG guidance) ([#76910](https://github.com/WordPress/gutenberg/pull/76910)). | ||
|
|
||
| ### Enhancements |
There was a problem hiding this comment.
Nit: move to unreleased section after rebasing
There was a problem hiding this comment.
We should probably add a section in CONTRIBUTING.md in the CSS architecture section about Global CSS defense — what it is, why it exists, how it works, when to use it.
# Conflicts: # packages/ui/src/text/text.tsx
* InputControl: Add defense styles * Textarea: Add defense styles * Link: Add defense styles * Use Link component for links * Button: Add defense styles * Fieldset: Add defense styles * Text: Add defense styles * Add links to stylesheets * Add changelog * Move import ordering * Fix anchor transition * Use `0 solid transparent` for outline fallbacks * Improve clarity of textarea defenses * Set paragraph margin fallback to 0 * Fix changelog * Add documentation to CONTRIBUTING.md Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: simison <simison@git.wordpress.org>
This updates the pinned commit hash of the Gutenberg repository from `5426109cdaf45828ef28ff8527d7d38e7e75fe74` (version `22.9.0`) to `7295bd91a3c2b64bb11dde0a12313210d9d16a12` (version `23.0.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v22.9.0..v23.0.0. The following commits are included: - Classify admin-ui and dataviews to components (WordPress/gutenberg#76959) - Add performance metrics for client-side media processing (WordPress/gutenberg#76792) - Connectors: Update help text from 'reset' to 'manage' (WordPress/gutenberg#76963) - Connectors: Hide Akismet unless already installed (WordPress/gutenberg#76962) - Remove unused catch block variables across the codebase (WordPress/gutenberg#76969) - Wrap sync update processing in try/catch (WordPress/gutenberg#76968) - Backport: Improve validation and permission checks for `WP_HTTP_Polling_Sync_Server` (WordPress/gutenberg#76987) - BlockMover: Remove unused disabled button props (WordPress/gutenberg#76993) - Core Data: Fix incorrect pagination for non-paginated entities (WordPress/gutenberg#76406) - Block Editor: Display shortcuts for moving blocks via tooltips (WordPress/gutenberg#76992) - Convert directories in test/ to workspaces (WordPress/gutenberg#74684) - RTC: Fix core/table cell merging (WordPress/gutenberg#76913) - Components: Extract the autocomplete matcher into a separate function (WordPress/gutenberg#76957) - Added Context for Next/Prev Enlarge Image (WordPress/gutenberg#76967) - Build Tools: Update TypeScript to 6.0.2 (WordPress/gutenberg#77010) - Text: Remove UA margins (WordPress/gutenberg#76970) - Fix pre-existing lint errors across the codebase (WordPress/gutenberg#77002) - Fix failing 'WP_HTTP_Polling_Sync_Server' unit test (WordPress/gutenberg#77025) - Card: Set default foreground color on root (WordPress/gutenberg#77013) - TypeScript: Migrate a11y package to TS (WordPress/gutenberg#70680) - Button: Remove unused Storybook story stylesheet (WordPress/gutenberg#77031) - Improve CSS setup instructions in package readmes (WordPress/gutenberg#76975) - Use Link component in details story example (WordPress/gutenberg#76997) - @wordpress/ui: Add global CSS defense module (WordPress/gutenberg#76783) - Autocompleters: Move and improve links search (WordPress/gutenberg#76995) - Autocomplete: Refactor useAutocomplete to use useReducer (WordPress/gutenberg#77020) - Components: Fix autocomplete overlapping trigger matching (WordPress/gutenberg#77018) - Fix: A sentence has no ending punctuation in README.md file. (WordPress/gutenberg#77027) - `ValidatedRangeControl`: Fix aria-label rendered as [object Object] (WordPress/gutenberg#77042) - HStack, VStack: Mark as not recommended for use (WordPress/gutenberg#77041) - Tests: Fix wp-env scripts not found in test workspaces (WordPress/gutenberg#77055) - Bump the github-actions group across 1 directory with 2 updates (WordPress/gutenberg#77030) - Autocomplete: Clarify 'isDebounced' setting limitation (WordPress/gutenberg#77062) - Fix SyntaxError in Autocompleter UI when pasting matching content (WordPress/gutenberg#76961) - Connectors: account for mu-plugins when resolving plugin.file status (WordPress/gutenberg#76994) - Storybook: Fix E2E subpath exports and add CI build smoke test (WordPress/gutenberg#77034) - Fix Storybook cursor Default option passing theme token (WordPress/gutenberg#77037) - Storybook: Enable theming toolbar for wp-components (WordPress/gutenberg#77038) - RTC: Fix "Edit as HTML" content reset during collaboration (WordPress/gutenberg#77043) - RTC: Fix inline inserter reset on update sync (WordPress/gutenberg#76980) - RTC: Predefined retry schedules for disconnect dialog, make more lenient (WordPress/gutenberg#76966) - Block Editor: Prevent Enter key from inserting paragraphs in contentOnly sections (WordPress/gutenberg#76989) - Editor: Fix 'selectedNote' action PHPDoc (WordPress/gutenberg#77080) - Tests: Fix argument forwarding for workspace test scripts (WordPress/gutenberg#77083) - Search block: Derive 'isSearchFieldHidden' value (WordPress/gutenberg#77082) - Cover block: fix embed video background Error 153 in editor (WordPress/gutenberg#76904) - Fields: Fix `postContentInfoField` when there are edits (WordPress/gutenberg#76901) - Restore original template registration tests alongside activation variants (WordPress/gutenberg#77068) - i18n: Make sprintf return FormattedText for type-safe createInterpolateElement (WordPress/gutenberg#76974) - Block Editor store: refactor controlledInnerBlocks to Set (WordPress/gutenberg#77094) - DataForm: support disabled controls (WordPress/gutenberg#77090) - ESLint plugin: Disable `jsx-a11y/heading-has-content` (WordPress/gutenberg#77073) - Remove remaining esModuleInterop usage (WordPress/gutenberg#77095) - Avoid stale values in core/cover block for RTC compatibility (WordPress/gutenberg#76916) - RTC: Add optional `shouldSync` function to entity sync config (WordPress/gutenberg#76947) - Bump oras-project/setup-oras (WordPress/gutenberg#77096) - RTC: Change SyncConnectionModal to isSyncConnectionErrorHandled filter and drop IS_GUTENBERG_PLUGIN check (WordPress/gutenberg#76853) - RTC: Respect WP_ALLOW_COLLABORATION in Gutenberg for activation hook (WordPress/gutenberg#77084) - Add iteration issue template (WordPress/gutenberg#77113) - Media Modal Experiment: Set matching picker grid layout properties for when a user switches between layouts (WordPress/gutenberg#77118) - contentOnly template lock: Fix block insertion and removal rules (WordPress/gutenberg#77119) - Global Styles Revisions: Fix footer overflow (WordPress/gutenberg#77103) - updateBlockListSettings: convert state to Map, do all updates in one action (WordPress/gutenberg#46392) - DataViews: Fix `compact` density clipping and remove top/bottom padding (WordPress/gutenberg#77054) - Icons: Override WP_Icons_Registry singleton with Gutenberg icons registry (WordPress/gutenberg#76455) - Button: Remove obsolete Safari + VoiceOver workaround (WordPress/gutenberg#77107) - E2E Tests: Ensure artifacts generate correctly and remove unnecessary artifacts (WordPress/gutenberg#77093) - UI `Text`: Mark as recommended (WordPress/gutenberg#77044) - ui/AlertDialog: better async confirm APIs, fully use base ui's `AlertDialog` (WordPress/gutenberg#76937) - BlockStyleVariationOverridesWithConfig: change name and fix lint errors (WordPress/gutenberg#77130) - Add `.scss` files to CSS module linting (WordPress/gutenberg#77140) - BoxControl: remove unused state for icon side (WordPress/gutenberg#77143) - Fix overflow of Highlighted white-space in Code Block (WordPress/gutenberg#77085) - move pseudo-state slicing logic into useStyle hook (WordPress/gutenberg#77104) - Autocomplete: Remove getAutoCompleterUI factory pattern (WordPress/gutenberg#77048) - Add `date` field in templates and template parts (WordPress/gutenberg#77134) - Revisions: Simplify fetching (WordPress/gutenberg#77086) - Remove 'Home' and 'End' key usage from Navigation Tests (WordPress/gutenberg#77102) - Guidelines: Update actions-section and import/export workflow (WordPress/gutenberg#76621) - Image block: Hide drag handles while an upload is in progress (WordPress/gutenberg#77121) - Build: Fix glob ignore patterns in dot-prefixed directories (WordPress/gutenberg#75114) - Added missing documentation in `collaboration.php` (WordPress/gutenberg#77173) - `@wordpress/ui`: add `Popover` (WordPress/gutenberg#76438) - Add Site Tagline and Site Title to Design > Identity panel (WordPress/gutenberg#76264) - Revision: Fix 'Show changes' button reset state (WordPress/gutenberg#77122) - Components: update React function names for better ESLint detection (WordPress/gutenberg#77148) - Link picker: Decode HTML entities in link preview title (WordPress/gutenberg#77170) - MediaEdit: handle '*' wildcard in validateMimeType (WordPress/gutenberg#77168) - Search block : Match behaviour of global styling for border and color with local styling (inspector controls) to remove inconsistency (WordPress/gutenberg#77060) - Re-order spacing side controls when unlinked (WordPress/gutenberg#66317) - Dataviews: remove unneeded ref callbacks (WordPress/gutenberg#77179) - Experiment: Add revisions panel to templates, template parts and patterns (WordPress/gutenberg#77008) - Guidelines CPT: Changes slug from wp_content_guidelines to wp_guidelines (WordPress/gutenberg#77147) - TextArea: add disabled styles (WordPress/gutenberg#77129) - Writing Flow: Fix format toolbar not appearing when selecting text from block edge (WordPress/gutenberg#77136) - DataForm: Remove `text-transform` from `panel` field labels (WordPress/gutenberg#77196) - FormTokenField: fix disabled styles (WordPress/gutenberg#77137) - Admin UI: Increase page header vertical padding (WordPress/gutenberg#77152) - Use entity link title for link control preview (WordPress/gutenberg#77155) - TypeScript: migrate annotations package to TS (WordPress/gutenberg#70602) - refactor: migrate bin/api-docs to tools/api-docs as workspace `@wordpress/api-docs-generator` (WordPress/gutenberg#77019) - TypeScript: Migrate viewport package (WordPress/gutenberg#71118) - UI/Tooltip: Add usage guidelines documentation (WordPress/gutenberg#77158) - RadioControl: add support for disabling radio group (WordPress/gutenberg#77127) - Upgrade ESLint to v10 (WordPress/gutenberg#76654) - Add e2e test coverage for the Guidelines settings page (WordPress/gutenberg#77192) - Admin UI: Update Page background color to surface-neutral (WordPress/gutenberg#76869) - Fix lint-staged API docs path (WordPress/gutenberg#77203) - PresetInputControl: Fix clearing of numeric value in custom input control (WordPress/gutenberg#77139) - Upload external media: Ensure notice only fires once (WordPress/gutenberg#77218) - Checkbox: fix disabled styles (WordPress/gutenberg#77132) - FormToggle: Update disabled styles (WordPress/gutenberg#77208) - Calendar: fix disabled styles (WordPress/gutenberg#77138) - Textarea: remove unnecessary styles (WordPress/gutenberg#77221) - Search Block: Ensure color settings apply to input field when button is disabled (WordPress/gutenberg#77219) - iAPI Docs: Fix typos, code errors, and inaccuracies in the documentation (WordPress/gutenberg#76636) - Connectors: don't clobber third-party custom render in registerDefaultConnectors (WordPress/gutenberg#77116) - Guidelines: Improve guideline revision UX (WordPress/gutenberg#76560) - ui/`Dialog`: update Header layout, refactor Title to use Text (WordPress/gutenberg#77161) - ui/docs: add additional global css setup instructions (WordPress/gutenberg#77228) - ui/VisuallyHidden: Standardize composition pattern (WordPress/gutenberg#77190) - ui: expose `container` portal prop on all overlay Popup components (WordPress/gutenberg#77163) - Components: Use `--wpds-cursor-control` for interactive controls (Sass only) (WordPress/gutenberg#76786) - Card: Remove redundant margin reset from Card.Title (WordPress/gutenberg#77187) - Theme: Rename typography tokens to use "typography" prefix (WordPress/gutenberg#76912) - UI: Normalize render prop and ref forwarding patterns (WordPress/gutenberg#77160) - Ensure "Retry" button is stable during retries (WordPress/gutenberg#77234) - RTC: Improve array attribute stability when structural changes occur (WordPress/gutenberg#77164) - Env: Fix loopback requests when running on non-default ports (WordPress/gutenberg#77057) - Connectors: Replace speak() with notice store for state changes (WordPress/gutenberg#77174) - Core Data: Fix 'useEntityProp' for raw attributes (WordPress/gutenberg#77120) - Use image.copyMemory() for batch thumbnail generation (WordPress/gutenberg#76979) - Post Author Biography: Preserve occurance of white spaces (WordPress/gutenberg#71133) - Fix PatternsActions prop name from postType to type (WordPress/gutenberg#77251) - Resolve package-lock.json inconsistency for @babel/eslint-parser (WordPress/gutenberg#77256) - Fix duotone filter not applying on style variation switch (WordPress/gutenberg#77229) - Fix: restore editor canvas padding in classic themes (WordPress/gutenberg#76864) - DataViews: simplify `defaultLayouts` prop (WordPress/gutenberg#77232) - getMergedItemsIds: receive full page bigger than perPage (WordPress/gutenberg#77262) - FormTokenField: remove unnecessary styles (WordPress/gutenberg#77263) - TypeScript: Migrate `packages/list-reusable-blocks` package to TypeScript (WordPress/gutenberg#70518) - RTC: Add filterable flag for meta box RTC compatibility (WordPress/gutenberg#76939) - RTC: Fix disconnect dialog due to uneditable entity (WordPress/gutenberg#77242) - Guidelines: Try removing the jsxRuntime pragma and see what happens (WordPress/gutenberg#77255) - DataForm: Show tooltip in edit button in `panel` layout (WordPress/gutenberg#77024) - blocks: Convert blocks package to TypeScript (WordPress/gutenberg#76312) - Fix Gutenberg_REST_View_Config_Controller_7_1 PHP warnings (WordPress/gutenberg#77290) - renamed focus visible (WordPress/gutenberg#77292) - page.waitForFunction: fix call arguments (WordPress/gutenberg#77300) - Tabs: Simplify anchor handling (WordPress/gutenberg#77189) - Tests: Auto-fix some new 'eslint-plugin-playwright' warnings (WordPress/gutenberg#77314) - Tab Menu Item: simplify active tab menu item style (WordPress/gutenberg#77195) - Eslint: Suggest alternative in `no-setting-ds-tokens` rule (WordPress/gutenberg#77154) - Autocomplete: Fix flaky e2e tests (WordPress/gutenberg#77322) - UI: Update `@base-ui/react` from `1.3.0` to `1.4.0` (WordPress/gutenberg#77308) - Docs: Add README for DatePicker and TimePicker Components (WordPress/gutenberg#70365) - UI: use Text component for Badge typography (WordPress/gutenberg#77295) - Block Editor: Extract getElementCSSRules from useBlockProps (WordPress/gutenberg#77327) - Edit Post: Fix warning in 'useMetaBoxInitialization' hook (WordPress/gutenberg#77311) - Update the page slug we link to for the AI plugin after the plugin has been installed and activated (WordPress/gutenberg#77336) - Guidelines CPT: Rename references from content guidelines to guidelines (WordPress/gutenberg#77223) - Dialog: add explicit margin-inline-end rule to Title (WordPress/gutenberg#77334) - Remove sandbox `allow-same-origin` for core/html blocks (WordPress/gutenberg#77212) - Block Directory: Use `--wpds-cursor-control` design token (WordPress/gutenberg#77330) - Registers wp_guideline_type taxonomy (WordPress/gutenberg#77156) - DataForm: Add min/max date range support for date and datetime fields (WordPress/gutenberg#77201) - Separator Block: Apply default block variation when inserting via `---` shortcut (WordPress/gutenberg#77135) - Paragraph: Prevent `onEnter` splitting of parent block when insertion of that block type is not allowed (WordPress/gutenberg#77291) - Media Upload Modal: Persist view configuration (WordPress/gutenberg#77288) - Image block: Validate attachment ID exists before treating image as local (WordPress/gutenberg#77178) - Tabs: remove sequential numbering from new tab labels (WordPress/gutenberg#77321) - DataViews: Use `--wpds-cursor-control` design token for interactive controls (WordPress/gutenberg#77259) - Post Editor: Store metaboxes RTC-compatible flag on location entries (WordPress/gutenberg#77361) - Guidelines CPT: Skip registration when post type already exists (WordPress/gutenberg#77486) - RTC: Fixed orphaned meta causing dirty editor state (WordPress/gutenberg#77529) - Guidelines: Make the CPT type-aware (WordPress/gutenberg#77491) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65557. git-svn-id: https://develop.svn.wordpress.org/trunk@62580 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned commit hash of the Gutenberg repository from `5426109cdaf45828ef28ff8527d7d38e7e75fe74` (version `22.9.0`) to `7295bd91a3c2b64bb11dde0a12313210d9d16a12` (version `23.0.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v22.9.0..v23.0.0. The following commits are included: - Classify admin-ui and dataviews to components (WordPress/gutenberg#76959) - Add performance metrics for client-side media processing (WordPress/gutenberg#76792) - Connectors: Update help text from 'reset' to 'manage' (WordPress/gutenberg#76963) - Connectors: Hide Akismet unless already installed (WordPress/gutenberg#76962) - Remove unused catch block variables across the codebase (WordPress/gutenberg#76969) - Wrap sync update processing in try/catch (WordPress/gutenberg#76968) - Backport: Improve validation and permission checks for `WP_HTTP_Polling_Sync_Server` (WordPress/gutenberg#76987) - BlockMover: Remove unused disabled button props (WordPress/gutenberg#76993) - Core Data: Fix incorrect pagination for non-paginated entities (WordPress/gutenberg#76406) - Block Editor: Display shortcuts for moving blocks via tooltips (WordPress/gutenberg#76992) - Convert directories in test/ to workspaces (WordPress/gutenberg#74684) - RTC: Fix core/table cell merging (WordPress/gutenberg#76913) - Components: Extract the autocomplete matcher into a separate function (WordPress/gutenberg#76957) - Added Context for Next/Prev Enlarge Image (WordPress/gutenberg#76967) - Build Tools: Update TypeScript to 6.0.2 (WordPress/gutenberg#77010) - Text: Remove UA margins (WordPress/gutenberg#76970) - Fix pre-existing lint errors across the codebase (WordPress/gutenberg#77002) - Fix failing 'WP_HTTP_Polling_Sync_Server' unit test (WordPress/gutenberg#77025) - Card: Set default foreground color on root (WordPress/gutenberg#77013) - TypeScript: Migrate a11y package to TS (WordPress/gutenberg#70680) - Button: Remove unused Storybook story stylesheet (WordPress/gutenberg#77031) - Improve CSS setup instructions in package readmes (WordPress/gutenberg#76975) - Use Link component in details story example (WordPress/gutenberg#76997) - @wordpress/ui: Add global CSS defense module (WordPress/gutenberg#76783) - Autocompleters: Move and improve links search (WordPress/gutenberg#76995) - Autocomplete: Refactor useAutocomplete to use useReducer (WordPress/gutenberg#77020) - Components: Fix autocomplete overlapping trigger matching (WordPress/gutenberg#77018) - Fix: A sentence has no ending punctuation in README.md file. (WordPress/gutenberg#77027) - `ValidatedRangeControl`: Fix aria-label rendered as [object Object] (WordPress/gutenberg#77042) - HStack, VStack: Mark as not recommended for use (WordPress/gutenberg#77041) - Tests: Fix wp-env scripts not found in test workspaces (WordPress/gutenberg#77055) - Bump the github-actions group across 1 directory with 2 updates (WordPress/gutenberg#77030) - Autocomplete: Clarify 'isDebounced' setting limitation (WordPress/gutenberg#77062) - Fix SyntaxError in Autocompleter UI when pasting matching content (WordPress/gutenberg#76961) - Connectors: account for mu-plugins when resolving plugin.file status (WordPress/gutenberg#76994) - Storybook: Fix E2E subpath exports and add CI build smoke test (WordPress/gutenberg#77034) - Fix Storybook cursor Default option passing theme token (WordPress/gutenberg#77037) - Storybook: Enable theming toolbar for wp-components (WordPress/gutenberg#77038) - RTC: Fix "Edit as HTML" content reset during collaboration (WordPress/gutenberg#77043) - RTC: Fix inline inserter reset on update sync (WordPress/gutenberg#76980) - RTC: Predefined retry schedules for disconnect dialog, make more lenient (WordPress/gutenberg#76966) - Block Editor: Prevent Enter key from inserting paragraphs in contentOnly sections (WordPress/gutenberg#76989) - Editor: Fix 'selectedNote' action PHPDoc (WordPress/gutenberg#77080) - Tests: Fix argument forwarding for workspace test scripts (WordPress/gutenberg#77083) - Search block: Derive 'isSearchFieldHidden' value (WordPress/gutenberg#77082) - Cover block: fix embed video background Error 153 in editor (WordPress/gutenberg#76904) - Fields: Fix `postContentInfoField` when there are edits (WordPress/gutenberg#76901) - Restore original template registration tests alongside activation variants (WordPress/gutenberg#77068) - i18n: Make sprintf return FormattedText for type-safe createInterpolateElement (WordPress/gutenberg#76974) - Block Editor store: refactor controlledInnerBlocks to Set (WordPress/gutenberg#77094) - DataForm: support disabled controls (WordPress/gutenberg#77090) - ESLint plugin: Disable `jsx-a11y/heading-has-content` (WordPress/gutenberg#77073) - Remove remaining esModuleInterop usage (WordPress/gutenberg#77095) - Avoid stale values in core/cover block for RTC compatibility (WordPress/gutenberg#76916) - RTC: Add optional `shouldSync` function to entity sync config (WordPress/gutenberg#76947) - Bump oras-project/setup-oras (WordPress/gutenberg#77096) - RTC: Change SyncConnectionModal to isSyncConnectionErrorHandled filter and drop IS_GUTENBERG_PLUGIN check (WordPress/gutenberg#76853) - RTC: Respect WP_ALLOW_COLLABORATION in Gutenberg for activation hook (WordPress/gutenberg#77084) - Add iteration issue template (WordPress/gutenberg#77113) - Media Modal Experiment: Set matching picker grid layout properties for when a user switches between layouts (WordPress/gutenberg#77118) - contentOnly template lock: Fix block insertion and removal rules (WordPress/gutenberg#77119) - Global Styles Revisions: Fix footer overflow (WordPress/gutenberg#77103) - updateBlockListSettings: convert state to Map, do all updates in one action (WordPress/gutenberg#46392) - DataViews: Fix `compact` density clipping and remove top/bottom padding (WordPress/gutenberg#77054) - Icons: Override WP_Icons_Registry singleton with Gutenberg icons registry (WordPress/gutenberg#76455) - Button: Remove obsolete Safari + VoiceOver workaround (WordPress/gutenberg#77107) - E2E Tests: Ensure artifacts generate correctly and remove unnecessary artifacts (WordPress/gutenberg#77093) - UI `Text`: Mark as recommended (WordPress/gutenberg#77044) - ui/AlertDialog: better async confirm APIs, fully use base ui's `AlertDialog` (WordPress/gutenberg#76937) - BlockStyleVariationOverridesWithConfig: change name and fix lint errors (WordPress/gutenberg#77130) - Add `.scss` files to CSS module linting (WordPress/gutenberg#77140) - BoxControl: remove unused state for icon side (WordPress/gutenberg#77143) - Fix overflow of Highlighted white-space in Code Block (WordPress/gutenberg#77085) - move pseudo-state slicing logic into useStyle hook (WordPress/gutenberg#77104) - Autocomplete: Remove getAutoCompleterUI factory pattern (WordPress/gutenberg#77048) - Add `date` field in templates and template parts (WordPress/gutenberg#77134) - Revisions: Simplify fetching (WordPress/gutenberg#77086) - Remove 'Home' and 'End' key usage from Navigation Tests (WordPress/gutenberg#77102) - Guidelines: Update actions-section and import/export workflow (WordPress/gutenberg#76621) - Image block: Hide drag handles while an upload is in progress (WordPress/gutenberg#77121) - Build: Fix glob ignore patterns in dot-prefixed directories (WordPress/gutenberg#75114) - Added missing documentation in `collaboration.php` (WordPress/gutenberg#77173) - `@wordpress/ui`: add `Popover` (WordPress/gutenberg#76438) - Add Site Tagline and Site Title to Design > Identity panel (WordPress/gutenberg#76264) - Revision: Fix 'Show changes' button reset state (WordPress/gutenberg#77122) - Components: update React function names for better ESLint detection (WordPress/gutenberg#77148) - Link picker: Decode HTML entities in link preview title (WordPress/gutenberg#77170) - MediaEdit: handle '*' wildcard in validateMimeType (WordPress/gutenberg#77168) - Search block : Match behaviour of global styling for border and color with local styling (inspector controls) to remove inconsistency (WordPress/gutenberg#77060) - Re-order spacing side controls when unlinked (WordPress/gutenberg#66317) - Dataviews: remove unneeded ref callbacks (WordPress/gutenberg#77179) - Experiment: Add revisions panel to templates, template parts and patterns (WordPress/gutenberg#77008) - Guidelines CPT: Changes slug from wp_content_guidelines to wp_guidelines (WordPress/gutenberg#77147) - TextArea: add disabled styles (WordPress/gutenberg#77129) - Writing Flow: Fix format toolbar not appearing when selecting text from block edge (WordPress/gutenberg#77136) - DataForm: Remove `text-transform` from `panel` field labels (WordPress/gutenberg#77196) - FormTokenField: fix disabled styles (WordPress/gutenberg#77137) - Admin UI: Increase page header vertical padding (WordPress/gutenberg#77152) - Use entity link title for link control preview (WordPress/gutenberg#77155) - TypeScript: migrate annotations package to TS (WordPress/gutenberg#70602) - refactor: migrate bin/api-docs to tools/api-docs as workspace `@wordpress/api-docs-generator` (WordPress/gutenberg#77019) - TypeScript: Migrate viewport package (WordPress/gutenberg#71118) - UI/Tooltip: Add usage guidelines documentation (WordPress/gutenberg#77158) - RadioControl: add support for disabling radio group (WordPress/gutenberg#77127) - Upgrade ESLint to v10 (WordPress/gutenberg#76654) - Add e2e test coverage for the Guidelines settings page (WordPress/gutenberg#77192) - Admin UI: Update Page background color to surface-neutral (WordPress/gutenberg#76869) - Fix lint-staged API docs path (WordPress/gutenberg#77203) - PresetInputControl: Fix clearing of numeric value in custom input control (WordPress/gutenberg#77139) - Upload external media: Ensure notice only fires once (WordPress/gutenberg#77218) - Checkbox: fix disabled styles (WordPress/gutenberg#77132) - FormToggle: Update disabled styles (WordPress/gutenberg#77208) - Calendar: fix disabled styles (WordPress/gutenberg#77138) - Textarea: remove unnecessary styles (WordPress/gutenberg#77221) - Search Block: Ensure color settings apply to input field when button is disabled (WordPress/gutenberg#77219) - iAPI Docs: Fix typos, code errors, and inaccuracies in the documentation (WordPress/gutenberg#76636) - Connectors: don't clobber third-party custom render in registerDefaultConnectors (WordPress/gutenberg#77116) - Guidelines: Improve guideline revision UX (WordPress/gutenberg#76560) - ui/`Dialog`: update Header layout, refactor Title to use Text (WordPress/gutenberg#77161) - ui/docs: add additional global css setup instructions (WordPress/gutenberg#77228) - ui/VisuallyHidden: Standardize composition pattern (WordPress/gutenberg#77190) - ui: expose `container` portal prop on all overlay Popup components (WordPress/gutenberg#77163) - Components: Use `--wpds-cursor-control` for interactive controls (Sass only) (WordPress/gutenberg#76786) - Card: Remove redundant margin reset from Card.Title (WordPress/gutenberg#77187) - Theme: Rename typography tokens to use "typography" prefix (WordPress/gutenberg#76912) - UI: Normalize render prop and ref forwarding patterns (WordPress/gutenberg#77160) - Ensure "Retry" button is stable during retries (WordPress/gutenberg#77234) - RTC: Improve array attribute stability when structural changes occur (WordPress/gutenberg#77164) - Env: Fix loopback requests when running on non-default ports (WordPress/gutenberg#77057) - Connectors: Replace speak() with notice store for state changes (WordPress/gutenberg#77174) - Core Data: Fix 'useEntityProp' for raw attributes (WordPress/gutenberg#77120) - Use image.copyMemory() for batch thumbnail generation (WordPress/gutenberg#76979) - Post Author Biography: Preserve occurance of white spaces (WordPress/gutenberg#71133) - Fix PatternsActions prop name from postType to type (WordPress/gutenberg#77251) - Resolve package-lock.json inconsistency for @babel/eslint-parser (WordPress/gutenberg#77256) - Fix duotone filter not applying on style variation switch (WordPress/gutenberg#77229) - Fix: restore editor canvas padding in classic themes (WordPress/gutenberg#76864) - DataViews: simplify `defaultLayouts` prop (WordPress/gutenberg#77232) - getMergedItemsIds: receive full page bigger than perPage (WordPress/gutenberg#77262) - FormTokenField: remove unnecessary styles (WordPress/gutenberg#77263) - TypeScript: Migrate `packages/list-reusable-blocks` package to TypeScript (WordPress/gutenberg#70518) - RTC: Add filterable flag for meta box RTC compatibility (WordPress/gutenberg#76939) - RTC: Fix disconnect dialog due to uneditable entity (WordPress/gutenberg#77242) - Guidelines: Try removing the jsxRuntime pragma and see what happens (WordPress/gutenberg#77255) - DataForm: Show tooltip in edit button in `panel` layout (WordPress/gutenberg#77024) - blocks: Convert blocks package to TypeScript (WordPress/gutenberg#76312) - Fix Gutenberg_REST_View_Config_Controller_7_1 PHP warnings (WordPress/gutenberg#77290) - renamed focus visible (WordPress/gutenberg#77292) - page.waitForFunction: fix call arguments (WordPress/gutenberg#77300) - Tabs: Simplify anchor handling (WordPress/gutenberg#77189) - Tests: Auto-fix some new 'eslint-plugin-playwright' warnings (WordPress/gutenberg#77314) - Tab Menu Item: simplify active tab menu item style (WordPress/gutenberg#77195) - Eslint: Suggest alternative in `no-setting-ds-tokens` rule (WordPress/gutenberg#77154) - Autocomplete: Fix flaky e2e tests (WordPress/gutenberg#77322) - UI: Update `@base-ui/react` from `1.3.0` to `1.4.0` (WordPress/gutenberg#77308) - Docs: Add README for DatePicker and TimePicker Components (WordPress/gutenberg#70365) - UI: use Text component for Badge typography (WordPress/gutenberg#77295) - Block Editor: Extract getElementCSSRules from useBlockProps (WordPress/gutenberg#77327) - Edit Post: Fix warning in 'useMetaBoxInitialization' hook (WordPress/gutenberg#77311) - Update the page slug we link to for the AI plugin after the plugin has been installed and activated (WordPress/gutenberg#77336) - Guidelines CPT: Rename references from content guidelines to guidelines (WordPress/gutenberg#77223) - Dialog: add explicit margin-inline-end rule to Title (WordPress/gutenberg#77334) - Remove sandbox `allow-same-origin` for core/html blocks (WordPress/gutenberg#77212) - Block Directory: Use `--wpds-cursor-control` design token (WordPress/gutenberg#77330) - Registers wp_guideline_type taxonomy (WordPress/gutenberg#77156) - DataForm: Add min/max date range support for date and datetime fields (WordPress/gutenberg#77201) - Separator Block: Apply default block variation when inserting via `---` shortcut (WordPress/gutenberg#77135) - Paragraph: Prevent `onEnter` splitting of parent block when insertion of that block type is not allowed (WordPress/gutenberg#77291) - Media Upload Modal: Persist view configuration (WordPress/gutenberg#77288) - Image block: Validate attachment ID exists before treating image as local (WordPress/gutenberg#77178) - Tabs: remove sequential numbering from new tab labels (WordPress/gutenberg#77321) - DataViews: Use `--wpds-cursor-control` design token for interactive controls (WordPress/gutenberg#77259) - Post Editor: Store metaboxes RTC-compatible flag on location entries (WordPress/gutenberg#77361) - Guidelines CPT: Skip registration when post type already exists (WordPress/gutenberg#77486) - RTC: Fixed orphaned meta causing dirty editor state (WordPress/gutenberg#77529) - Guidelines: Make the CPT type-aware (WordPress/gutenberg#77491) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65557. Built from https://develop.svn.wordpress.org/trunk@62580 git-svn-id: http://core.svn.wordpress.org/trunk@61860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the pinned commit hash of the Gutenberg repository from `5426109cdaf45828ef28ff8527d7d38e7e75fe74` (version `22.9.0`) to `7295bd91a3c2b64bb11dde0a12313210d9d16a12` (version `23.0.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v22.9.0..v23.0.0. The following commits are included: - Classify admin-ui and dataviews to components (WordPress/gutenberg#76959) - Add performance metrics for client-side media processing (WordPress/gutenberg#76792) - Connectors: Update help text from 'reset' to 'manage' (WordPress/gutenberg#76963) - Connectors: Hide Akismet unless already installed (WordPress/gutenberg#76962) - Remove unused catch block variables across the codebase (WordPress/gutenberg#76969) - Wrap sync update processing in try/catch (WordPress/gutenberg#76968) - Backport: Improve validation and permission checks for `WP_HTTP_Polling_Sync_Server` (WordPress/gutenberg#76987) - BlockMover: Remove unused disabled button props (WordPress/gutenberg#76993) - Core Data: Fix incorrect pagination for non-paginated entities (WordPress/gutenberg#76406) - Block Editor: Display shortcuts for moving blocks via tooltips (WordPress/gutenberg#76992) - Convert directories in test/ to workspaces (WordPress/gutenberg#74684) - RTC: Fix core/table cell merging (WordPress/gutenberg#76913) - Components: Extract the autocomplete matcher into a separate function (WordPress/gutenberg#76957) - Added Context for Next/Prev Enlarge Image (WordPress/gutenberg#76967) - Build Tools: Update TypeScript to 6.0.2 (WordPress/gutenberg#77010) - Text: Remove UA margins (WordPress/gutenberg#76970) - Fix pre-existing lint errors across the codebase (WordPress/gutenberg#77002) - Fix failing 'WP_HTTP_Polling_Sync_Server' unit test (WordPress/gutenberg#77025) - Card: Set default foreground color on root (WordPress/gutenberg#77013) - TypeScript: Migrate a11y package to TS (WordPress/gutenberg#70680) - Button: Remove unused Storybook story stylesheet (WordPress/gutenberg#77031) - Improve CSS setup instructions in package readmes (WordPress/gutenberg#76975) - Use Link component in details story example (WordPress/gutenberg#76997) - @wordpress/ui: Add global CSS defense module (WordPress/gutenberg#76783) - Autocompleters: Move and improve links search (WordPress/gutenberg#76995) - Autocomplete: Refactor useAutocomplete to use useReducer (WordPress/gutenberg#77020) - Components: Fix autocomplete overlapping trigger matching (WordPress/gutenberg#77018) - Fix: A sentence has no ending punctuation in README.md file. (WordPress/gutenberg#77027) - `ValidatedRangeControl`: Fix aria-label rendered as [object Object] (WordPress/gutenberg#77042) - HStack, VStack: Mark as not recommended for use (WordPress/gutenberg#77041) - Tests: Fix wp-env scripts not found in test workspaces (WordPress/gutenberg#77055) - Bump the github-actions group across 1 directory with 2 updates (WordPress/gutenberg#77030) - Autocomplete: Clarify 'isDebounced' setting limitation (WordPress/gutenberg#77062) - Fix SyntaxError in Autocompleter UI when pasting matching content (WordPress/gutenberg#76961) - Connectors: account for mu-plugins when resolving plugin.file status (WordPress/gutenberg#76994) - Storybook: Fix E2E subpath exports and add CI build smoke test (WordPress/gutenberg#77034) - Fix Storybook cursor Default option passing theme token (WordPress/gutenberg#77037) - Storybook: Enable theming toolbar for wp-components (WordPress/gutenberg#77038) - RTC: Fix "Edit as HTML" content reset during collaboration (WordPress/gutenberg#77043) - RTC: Fix inline inserter reset on update sync (WordPress/gutenberg#76980) - RTC: Predefined retry schedules for disconnect dialog, make more lenient (WordPress/gutenberg#76966) - Block Editor: Prevent Enter key from inserting paragraphs in contentOnly sections (WordPress/gutenberg#76989) - Editor: Fix 'selectedNote' action PHPDoc (WordPress/gutenberg#77080) - Tests: Fix argument forwarding for workspace test scripts (WordPress/gutenberg#77083) - Search block: Derive 'isSearchFieldHidden' value (WordPress/gutenberg#77082) - Cover block: fix embed video background Error 153 in editor (WordPress/gutenberg#76904) - Fields: Fix `postContentInfoField` when there are edits (WordPress/gutenberg#76901) - Restore original template registration tests alongside activation variants (WordPress/gutenberg#77068) - i18n: Make sprintf return FormattedText for type-safe createInterpolateElement (WordPress/gutenberg#76974) - Block Editor store: refactor controlledInnerBlocks to Set (WordPress/gutenberg#77094) - DataForm: support disabled controls (WordPress/gutenberg#77090) - ESLint plugin: Disable `jsx-a11y/heading-has-content` (WordPress/gutenberg#77073) - Remove remaining esModuleInterop usage (WordPress/gutenberg#77095) - Avoid stale values in core/cover block for RTC compatibility (WordPress/gutenberg#76916) - RTC: Add optional `shouldSync` function to entity sync config (WordPress/gutenberg#76947) - Bump oras-project/setup-oras (WordPress/gutenberg#77096) - RTC: Change SyncConnectionModal to isSyncConnectionErrorHandled filter and drop IS_GUTENBERG_PLUGIN check (WordPress/gutenberg#76853) - RTC: Respect WP_ALLOW_COLLABORATION in Gutenberg for activation hook (WordPress/gutenberg#77084) - Add iteration issue template (WordPress/gutenberg#77113) - Media Modal Experiment: Set matching picker grid layout properties for when a user switches between layouts (WordPress/gutenberg#77118) - contentOnly template lock: Fix block insertion and removal rules (WordPress/gutenberg#77119) - Global Styles Revisions: Fix footer overflow (WordPress/gutenberg#77103) - updateBlockListSettings: convert state to Map, do all updates in one action (WordPress/gutenberg#46392) - DataViews: Fix `compact` density clipping and remove top/bottom padding (WordPress/gutenberg#77054) - Icons: Override WP_Icons_Registry singleton with Gutenberg icons registry (WordPress/gutenberg#76455) - Button: Remove obsolete Safari + VoiceOver workaround (WordPress/gutenberg#77107) - E2E Tests: Ensure artifacts generate correctly and remove unnecessary artifacts (WordPress/gutenberg#77093) - UI `Text`: Mark as recommended (WordPress/gutenberg#77044) - ui/AlertDialog: better async confirm APIs, fully use base ui's `AlertDialog` (WordPress/gutenberg#76937) - BlockStyleVariationOverridesWithConfig: change name and fix lint errors (WordPress/gutenberg#77130) - Add `.scss` files to CSS module linting (WordPress/gutenberg#77140) - BoxControl: remove unused state for icon side (WordPress/gutenberg#77143) - Fix overflow of Highlighted white-space in Code Block (WordPress/gutenberg#77085) - move pseudo-state slicing logic into useStyle hook (WordPress/gutenberg#77104) - Autocomplete: Remove getAutoCompleterUI factory pattern (WordPress/gutenberg#77048) - Add `date` field in templates and template parts (WordPress/gutenberg#77134) - Revisions: Simplify fetching (WordPress/gutenberg#77086) - Remove 'Home' and 'End' key usage from Navigation Tests (WordPress/gutenberg#77102) - Guidelines: Update actions-section and import/export workflow (WordPress/gutenberg#76621) - Image block: Hide drag handles while an upload is in progress (WordPress/gutenberg#77121) - Build: Fix glob ignore patterns in dot-prefixed directories (WordPress/gutenberg#75114) - Added missing documentation in `collaboration.php` (WordPress/gutenberg#77173) - `@wordpress/ui`: add `Popover` (WordPress/gutenberg#76438) - Add Site Tagline and Site Title to Design > Identity panel (WordPress/gutenberg#76264) - Revision: Fix 'Show changes' button reset state (WordPress/gutenberg#77122) - Components: update React function names for better ESLint detection (WordPress/gutenberg#77148) - Link picker: Decode HTML entities in link preview title (WordPress/gutenberg#77170) - MediaEdit: handle '*' wildcard in validateMimeType (WordPress/gutenberg#77168) - Search block : Match behaviour of global styling for border and color with local styling (inspector controls) to remove inconsistency (WordPress/gutenberg#77060) - Re-order spacing side controls when unlinked (WordPress/gutenberg#66317) - Dataviews: remove unneeded ref callbacks (WordPress/gutenberg#77179) - Experiment: Add revisions panel to templates, template parts and patterns (WordPress/gutenberg#77008) - Guidelines CPT: Changes slug from wp_content_guidelines to wp_guidelines (WordPress/gutenberg#77147) - TextArea: add disabled styles (WordPress/gutenberg#77129) - Writing Flow: Fix format toolbar not appearing when selecting text from block edge (WordPress/gutenberg#77136) - DataForm: Remove `text-transform` from `panel` field labels (WordPress/gutenberg#77196) - FormTokenField: fix disabled styles (WordPress/gutenberg#77137) - Admin UI: Increase page header vertical padding (WordPress/gutenberg#77152) - Use entity link title for link control preview (WordPress/gutenberg#77155) - TypeScript: migrate annotations package to TS (WordPress/gutenberg#70602) - refactor: migrate bin/api-docs to tools/api-docs as workspace `@wordpress/api-docs-generator` (WordPress/gutenberg#77019) - TypeScript: Migrate viewport package (WordPress/gutenberg#71118) - UI/Tooltip: Add usage guidelines documentation (WordPress/gutenberg#77158) - RadioControl: add support for disabling radio group (WordPress/gutenberg#77127) - Upgrade ESLint to v10 (WordPress/gutenberg#76654) - Add e2e test coverage for the Guidelines settings page (WordPress/gutenberg#77192) - Admin UI: Update Page background color to surface-neutral (WordPress/gutenberg#76869) - Fix lint-staged API docs path (WordPress/gutenberg#77203) - PresetInputControl: Fix clearing of numeric value in custom input control (WordPress/gutenberg#77139) - Upload external media: Ensure notice only fires once (WordPress/gutenberg#77218) - Checkbox: fix disabled styles (WordPress/gutenberg#77132) - FormToggle: Update disabled styles (WordPress/gutenberg#77208) - Calendar: fix disabled styles (WordPress/gutenberg#77138) - Textarea: remove unnecessary styles (WordPress/gutenberg#77221) - Search Block: Ensure color settings apply to input field when button is disabled (WordPress/gutenberg#77219) - iAPI Docs: Fix typos, code errors, and inaccuracies in the documentation (WordPress/gutenberg#76636) - Connectors: don't clobber third-party custom render in registerDefaultConnectors (WordPress/gutenberg#77116) - Guidelines: Improve guideline revision UX (WordPress/gutenberg#76560) - ui/`Dialog`: update Header layout, refactor Title to use Text (WordPress/gutenberg#77161) - ui/docs: add additional global css setup instructions (WordPress/gutenberg#77228) - ui/VisuallyHidden: Standardize composition pattern (WordPress/gutenberg#77190) - ui: expose `container` portal prop on all overlay Popup components (WordPress/gutenberg#77163) - Components: Use `--wpds-cursor-control` for interactive controls (Sass only) (WordPress/gutenberg#76786) - Card: Remove redundant margin reset from Card.Title (WordPress/gutenberg#77187) - Theme: Rename typography tokens to use "typography" prefix (WordPress/gutenberg#76912) - UI: Normalize render prop and ref forwarding patterns (WordPress/gutenberg#77160) - Ensure "Retry" button is stable during retries (WordPress/gutenberg#77234) - RTC: Improve array attribute stability when structural changes occur (WordPress/gutenberg#77164) - Env: Fix loopback requests when running on non-default ports (WordPress/gutenberg#77057) - Connectors: Replace speak() with notice store for state changes (WordPress/gutenberg#77174) - Core Data: Fix 'useEntityProp' for raw attributes (WordPress/gutenberg#77120) - Use image.copyMemory() for batch thumbnail generation (WordPress/gutenberg#76979) - Post Author Biography: Preserve occurance of white spaces (WordPress/gutenberg#71133) - Fix PatternsActions prop name from postType to type (WordPress/gutenberg#77251) - Resolve package-lock.json inconsistency for @babel/eslint-parser (WordPress/gutenberg#77256) - Fix duotone filter not applying on style variation switch (WordPress/gutenberg#77229) - Fix: restore editor canvas padding in classic themes (WordPress/gutenberg#76864) - DataViews: simplify `defaultLayouts` prop (WordPress/gutenberg#77232) - getMergedItemsIds: receive full page bigger than perPage (WordPress/gutenberg#77262) - FormTokenField: remove unnecessary styles (WordPress/gutenberg#77263) - TypeScript: Migrate `packages/list-reusable-blocks` package to TypeScript (WordPress/gutenberg#70518) - RTC: Add filterable flag for meta box RTC compatibility (WordPress/gutenberg#76939) - RTC: Fix disconnect dialog due to uneditable entity (WordPress/gutenberg#77242) - Guidelines: Try removing the jsxRuntime pragma and see what happens (WordPress/gutenberg#77255) - DataForm: Show tooltip in edit button in `panel` layout (WordPress/gutenberg#77024) - blocks: Convert blocks package to TypeScript (WordPress/gutenberg#76312) - Fix Gutenberg_REST_View_Config_Controller_7_1 PHP warnings (WordPress/gutenberg#77290) - renamed focus visible (WordPress/gutenberg#77292) - page.waitForFunction: fix call arguments (WordPress/gutenberg#77300) - Tabs: Simplify anchor handling (WordPress/gutenberg#77189) - Tests: Auto-fix some new 'eslint-plugin-playwright' warnings (WordPress/gutenberg#77314) - Tab Menu Item: simplify active tab menu item style (WordPress/gutenberg#77195) - Eslint: Suggest alternative in `no-setting-ds-tokens` rule (WordPress/gutenberg#77154) - Autocomplete: Fix flaky e2e tests (WordPress/gutenberg#77322) - UI: Update `@base-ui/react` from `1.3.0` to `1.4.0` (WordPress/gutenberg#77308) - Docs: Add README for DatePicker and TimePicker Components (WordPress/gutenberg#70365) - UI: use Text component for Badge typography (WordPress/gutenberg#77295) - Block Editor: Extract getElementCSSRules from useBlockProps (WordPress/gutenberg#77327) - Edit Post: Fix warning in 'useMetaBoxInitialization' hook (WordPress/gutenberg#77311) - Update the page slug we link to for the AI plugin after the plugin has been installed and activated (WordPress/gutenberg#77336) - Guidelines CPT: Rename references from content guidelines to guidelines (WordPress/gutenberg#77223) - Dialog: add explicit margin-inline-end rule to Title (WordPress/gutenberg#77334) - Remove sandbox `allow-same-origin` for core/html blocks (WordPress/gutenberg#77212) - Block Directory: Use `--wpds-cursor-control` design token (WordPress/gutenberg#77330) - Registers wp_guideline_type taxonomy (WordPress/gutenberg#77156) - DataForm: Add min/max date range support for date and datetime fields (WordPress/gutenberg#77201) - Separator Block: Apply default block variation when inserting via `---` shortcut (WordPress/gutenberg#77135) - Paragraph: Prevent `onEnter` splitting of parent block when insertion of that block type is not allowed (WordPress/gutenberg#77291) - Media Upload Modal: Persist view configuration (WordPress/gutenberg#77288) - Image block: Validate attachment ID exists before treating image as local (WordPress/gutenberg#77178) - Tabs: remove sequential numbering from new tab labels (WordPress/gutenberg#77321) - DataViews: Use `--wpds-cursor-control` design token for interactive controls (WordPress/gutenberg#77259) - Post Editor: Store metaboxes RTC-compatible flag on location entries (WordPress/gutenberg#77361) - Guidelines CPT: Skip registration when post type already exists (WordPress/gutenberg#77486) - RTC: Fixed orphaned meta causing dirty editor state (WordPress/gutenberg#77529) - Guidelines: Make the CPT type-aware (WordPress/gutenberg#77491) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65557. git-svn-id: https://develop.svn.wordpress.org/trunk@62580 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned commit hash of the Gutenberg repository from `5426109cdaf45828ef28ff8527d7d38e7e75fe74` (version `22.9.0`) to `7295bd91a3c2b64bb11dde0a12313210d9d16a12` (version `23.0.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v22.9.0..v23.0.0. The following commits are included: - Classify admin-ui and dataviews to components (WordPress/gutenberg#76959) - Add performance metrics for client-side media processing (WordPress/gutenberg#76792) - Connectors: Update help text from 'reset' to 'manage' (WordPress/gutenberg#76963) - Connectors: Hide Akismet unless already installed (WordPress/gutenberg#76962) - Remove unused catch block variables across the codebase (WordPress/gutenberg#76969) - Wrap sync update processing in try/catch (WordPress/gutenberg#76968) - Backport: Improve validation and permission checks for `WP_HTTP_Polling_Sync_Server` (WordPress/gutenberg#76987) - BlockMover: Remove unused disabled button props (WordPress/gutenberg#76993) - Core Data: Fix incorrect pagination for non-paginated entities (WordPress/gutenberg#76406) - Block Editor: Display shortcuts for moving blocks via tooltips (WordPress/gutenberg#76992) - Convert directories in test/ to workspaces (WordPress/gutenberg#74684) - RTC: Fix core/table cell merging (WordPress/gutenberg#76913) - Components: Extract the autocomplete matcher into a separate function (WordPress/gutenberg#76957) - Added Context for Next/Prev Enlarge Image (WordPress/gutenberg#76967) - Build Tools: Update TypeScript to 6.0.2 (WordPress/gutenberg#77010) - Text: Remove UA margins (WordPress/gutenberg#76970) - Fix pre-existing lint errors across the codebase (WordPress/gutenberg#77002) - Fix failing 'WP_HTTP_Polling_Sync_Server' unit test (WordPress/gutenberg#77025) - Card: Set default foreground color on root (WordPress/gutenberg#77013) - TypeScript: Migrate a11y package to TS (WordPress/gutenberg#70680) - Button: Remove unused Storybook story stylesheet (WordPress/gutenberg#77031) - Improve CSS setup instructions in package readmes (WordPress/gutenberg#76975) - Use Link component in details story example (WordPress/gutenberg#76997) - @wordpress/ui: Add global CSS defense module (WordPress/gutenberg#76783) - Autocompleters: Move and improve links search (WordPress/gutenberg#76995) - Autocomplete: Refactor useAutocomplete to use useReducer (WordPress/gutenberg#77020) - Components: Fix autocomplete overlapping trigger matching (WordPress/gutenberg#77018) - Fix: A sentence has no ending punctuation in README.md file. (WordPress/gutenberg#77027) - `ValidatedRangeControl`: Fix aria-label rendered as [object Object] (WordPress/gutenberg#77042) - HStack, VStack: Mark as not recommended for use (WordPress/gutenberg#77041) - Tests: Fix wp-env scripts not found in test workspaces (WordPress/gutenberg#77055) - Bump the github-actions group across 1 directory with 2 updates (WordPress/gutenberg#77030) - Autocomplete: Clarify 'isDebounced' setting limitation (WordPress/gutenberg#77062) - Fix SyntaxError in Autocompleter UI when pasting matching content (WordPress/gutenberg#76961) - Connectors: account for mu-plugins when resolving plugin.file status (WordPress/gutenberg#76994) - Storybook: Fix E2E subpath exports and add CI build smoke test (WordPress/gutenberg#77034) - Fix Storybook cursor Default option passing theme token (WordPress/gutenberg#77037) - Storybook: Enable theming toolbar for wp-components (WordPress/gutenberg#77038) - RTC: Fix "Edit as HTML" content reset during collaboration (WordPress/gutenberg#77043) - RTC: Fix inline inserter reset on update sync (WordPress/gutenberg#76980) - RTC: Predefined retry schedules for disconnect dialog, make more lenient (WordPress/gutenberg#76966) - Block Editor: Prevent Enter key from inserting paragraphs in contentOnly sections (WordPress/gutenberg#76989) - Editor: Fix 'selectedNote' action PHPDoc (WordPress/gutenberg#77080) - Tests: Fix argument forwarding for workspace test scripts (WordPress/gutenberg#77083) - Search block: Derive 'isSearchFieldHidden' value (WordPress/gutenberg#77082) - Cover block: fix embed video background Error 153 in editor (WordPress/gutenberg#76904) - Fields: Fix `postContentInfoField` when there are edits (WordPress/gutenberg#76901) - Restore original template registration tests alongside activation variants (WordPress/gutenberg#77068) - i18n: Make sprintf return FormattedText for type-safe createInterpolateElement (WordPress/gutenberg#76974) - Block Editor store: refactor controlledInnerBlocks to Set (WordPress/gutenberg#77094) - DataForm: support disabled controls (WordPress/gutenberg#77090) - ESLint plugin: Disable `jsx-a11y/heading-has-content` (WordPress/gutenberg#77073) - Remove remaining esModuleInterop usage (WordPress/gutenberg#77095) - Avoid stale values in core/cover block for RTC compatibility (WordPress/gutenberg#76916) - RTC: Add optional `shouldSync` function to entity sync config (WordPress/gutenberg#76947) - Bump oras-project/setup-oras (WordPress/gutenberg#77096) - RTC: Change SyncConnectionModal to isSyncConnectionErrorHandled filter and drop IS_GUTENBERG_PLUGIN check (WordPress/gutenberg#76853) - RTC: Respect WP_ALLOW_COLLABORATION in Gutenberg for activation hook (WordPress/gutenberg#77084) - Add iteration issue template (WordPress/gutenberg#77113) - Media Modal Experiment: Set matching picker grid layout properties for when a user switches between layouts (WordPress/gutenberg#77118) - contentOnly template lock: Fix block insertion and removal rules (WordPress/gutenberg#77119) - Global Styles Revisions: Fix footer overflow (WordPress/gutenberg#77103) - updateBlockListSettings: convert state to Map, do all updates in one action (WordPress/gutenberg#46392) - DataViews: Fix `compact` density clipping and remove top/bottom padding (WordPress/gutenberg#77054) - Icons: Override WP_Icons_Registry singleton with Gutenberg icons registry (WordPress/gutenberg#76455) - Button: Remove obsolete Safari + VoiceOver workaround (WordPress/gutenberg#77107) - E2E Tests: Ensure artifacts generate correctly and remove unnecessary artifacts (WordPress/gutenberg#77093) - UI `Text`: Mark as recommended (WordPress/gutenberg#77044) - ui/AlertDialog: better async confirm APIs, fully use base ui's `AlertDialog` (WordPress/gutenberg#76937) - BlockStyleVariationOverridesWithConfig: change name and fix lint errors (WordPress/gutenberg#77130) - Add `.scss` files to CSS module linting (WordPress/gutenberg#77140) - BoxControl: remove unused state for icon side (WordPress/gutenberg#77143) - Fix overflow of Highlighted white-space in Code Block (WordPress/gutenberg#77085) - move pseudo-state slicing logic into useStyle hook (WordPress/gutenberg#77104) - Autocomplete: Remove getAutoCompleterUI factory pattern (WordPress/gutenberg#77048) - Add `date` field in templates and template parts (WordPress/gutenberg#77134) - Revisions: Simplify fetching (WordPress/gutenberg#77086) - Remove 'Home' and 'End' key usage from Navigation Tests (WordPress/gutenberg#77102) - Guidelines: Update actions-section and import/export workflow (WordPress/gutenberg#76621) - Image block: Hide drag handles while an upload is in progress (WordPress/gutenberg#77121) - Build: Fix glob ignore patterns in dot-prefixed directories (WordPress/gutenberg#75114) - Added missing documentation in `collaboration.php` (WordPress/gutenberg#77173) - `@wordpress/ui`: add `Popover` (WordPress/gutenberg#76438) - Add Site Tagline and Site Title to Design > Identity panel (WordPress/gutenberg#76264) - Revision: Fix 'Show changes' button reset state (WordPress/gutenberg#77122) - Components: update React function names for better ESLint detection (WordPress/gutenberg#77148) - Link picker: Decode HTML entities in link preview title (WordPress/gutenberg#77170) - MediaEdit: handle '*' wildcard in validateMimeType (WordPress/gutenberg#77168) - Search block : Match behaviour of global styling for border and color with local styling (inspector controls) to remove inconsistency (WordPress/gutenberg#77060) - Re-order spacing side controls when unlinked (WordPress/gutenberg#66317) - Dataviews: remove unneeded ref callbacks (WordPress/gutenberg#77179) - Experiment: Add revisions panel to templates, template parts and patterns (WordPress/gutenberg#77008) - Guidelines CPT: Changes slug from wp_content_guidelines to wp_guidelines (WordPress/gutenberg#77147) - TextArea: add disabled styles (WordPress/gutenberg#77129) - Writing Flow: Fix format toolbar not appearing when selecting text from block edge (WordPress/gutenberg#77136) - DataForm: Remove `text-transform` from `panel` field labels (WordPress/gutenberg#77196) - FormTokenField: fix disabled styles (WordPress/gutenberg#77137) - Admin UI: Increase page header vertical padding (WordPress/gutenberg#77152) - Use entity link title for link control preview (WordPress/gutenberg#77155) - TypeScript: migrate annotations package to TS (WordPress/gutenberg#70602) - refactor: migrate bin/api-docs to tools/api-docs as workspace `@wordpress/api-docs-generator` (WordPress/gutenberg#77019) - TypeScript: Migrate viewport package (WordPress/gutenberg#71118) - UI/Tooltip: Add usage guidelines documentation (WordPress/gutenberg#77158) - RadioControl: add support for disabling radio group (WordPress/gutenberg#77127) - Upgrade ESLint to v10 (WordPress/gutenberg#76654) - Add e2e test coverage for the Guidelines settings page (WordPress/gutenberg#77192) - Admin UI: Update Page background color to surface-neutral (WordPress/gutenberg#76869) - Fix lint-staged API docs path (WordPress/gutenberg#77203) - PresetInputControl: Fix clearing of numeric value in custom input control (WordPress/gutenberg#77139) - Upload external media: Ensure notice only fires once (WordPress/gutenberg#77218) - Checkbox: fix disabled styles (WordPress/gutenberg#77132) - FormToggle: Update disabled styles (WordPress/gutenberg#77208) - Calendar: fix disabled styles (WordPress/gutenberg#77138) - Textarea: remove unnecessary styles (WordPress/gutenberg#77221) - Search Block: Ensure color settings apply to input field when button is disabled (WordPress/gutenberg#77219) - iAPI Docs: Fix typos, code errors, and inaccuracies in the documentation (WordPress/gutenberg#76636) - Connectors: don't clobber third-party custom render in registerDefaultConnectors (WordPress/gutenberg#77116) - Guidelines: Improve guideline revision UX (WordPress/gutenberg#76560) - ui/`Dialog`: update Header layout, refactor Title to use Text (WordPress/gutenberg#77161) - ui/docs: add additional global css setup instructions (WordPress/gutenberg#77228) - ui/VisuallyHidden: Standardize composition pattern (WordPress/gutenberg#77190) - ui: expose `container` portal prop on all overlay Popup components (WordPress/gutenberg#77163) - Components: Use `--wpds-cursor-control` for interactive controls (Sass only) (WordPress/gutenberg#76786) - Card: Remove redundant margin reset from Card.Title (WordPress/gutenberg#77187) - Theme: Rename typography tokens to use "typography" prefix (WordPress/gutenberg#76912) - UI: Normalize render prop and ref forwarding patterns (WordPress/gutenberg#77160) - Ensure "Retry" button is stable during retries (WordPress/gutenberg#77234) - RTC: Improve array attribute stability when structural changes occur (WordPress/gutenberg#77164) - Env: Fix loopback requests when running on non-default ports (WordPress/gutenberg#77057) - Connectors: Replace speak() with notice store for state changes (WordPress/gutenberg#77174) - Core Data: Fix 'useEntityProp' for raw attributes (WordPress/gutenberg#77120) - Use image.copyMemory() for batch thumbnail generation (WordPress/gutenberg#76979) - Post Author Biography: Preserve occurance of white spaces (WordPress/gutenberg#71133) - Fix PatternsActions prop name from postType to type (WordPress/gutenberg#77251) - Resolve package-lock.json inconsistency for @babel/eslint-parser (WordPress/gutenberg#77256) - Fix duotone filter not applying on style variation switch (WordPress/gutenberg#77229) - Fix: restore editor canvas padding in classic themes (WordPress/gutenberg#76864) - DataViews: simplify `defaultLayouts` prop (WordPress/gutenberg#77232) - getMergedItemsIds: receive full page bigger than perPage (WordPress/gutenberg#77262) - FormTokenField: remove unnecessary styles (WordPress/gutenberg#77263) - TypeScript: Migrate `packages/list-reusable-blocks` package to TypeScript (WordPress/gutenberg#70518) - RTC: Add filterable flag for meta box RTC compatibility (WordPress/gutenberg#76939) - RTC: Fix disconnect dialog due to uneditable entity (WordPress/gutenberg#77242) - Guidelines: Try removing the jsxRuntime pragma and see what happens (WordPress/gutenberg#77255) - DataForm: Show tooltip in edit button in `panel` layout (WordPress/gutenberg#77024) - blocks: Convert blocks package to TypeScript (WordPress/gutenberg#76312) - Fix Gutenberg_REST_View_Config_Controller_7_1 PHP warnings (WordPress/gutenberg#77290) - renamed focus visible (WordPress/gutenberg#77292) - page.waitForFunction: fix call arguments (WordPress/gutenberg#77300) - Tabs: Simplify anchor handling (WordPress/gutenberg#77189) - Tests: Auto-fix some new 'eslint-plugin-playwright' warnings (WordPress/gutenberg#77314) - Tab Menu Item: simplify active tab menu item style (WordPress/gutenberg#77195) - Eslint: Suggest alternative in `no-setting-ds-tokens` rule (WordPress/gutenberg#77154) - Autocomplete: Fix flaky e2e tests (WordPress/gutenberg#77322) - UI: Update `@base-ui/react` from `1.3.0` to `1.4.0` (WordPress/gutenberg#77308) - Docs: Add README for DatePicker and TimePicker Components (WordPress/gutenberg#70365) - UI: use Text component for Badge typography (WordPress/gutenberg#77295) - Block Editor: Extract getElementCSSRules from useBlockProps (WordPress/gutenberg#77327) - Edit Post: Fix warning in 'useMetaBoxInitialization' hook (WordPress/gutenberg#77311) - Update the page slug we link to for the AI plugin after the plugin has been installed and activated (WordPress/gutenberg#77336) - Guidelines CPT: Rename references from content guidelines to guidelines (WordPress/gutenberg#77223) - Dialog: add explicit margin-inline-end rule to Title (WordPress/gutenberg#77334) - Remove sandbox `allow-same-origin` for core/html blocks (WordPress/gutenberg#77212) - Block Directory: Use `--wpds-cursor-control` design token (WordPress/gutenberg#77330) - Registers wp_guideline_type taxonomy (WordPress/gutenberg#77156) - DataForm: Add min/max date range support for date and datetime fields (WordPress/gutenberg#77201) - Separator Block: Apply default block variation when inserting via `---` shortcut (WordPress/gutenberg#77135) - Paragraph: Prevent `onEnter` splitting of parent block when insertion of that block type is not allowed (WordPress/gutenberg#77291) - Media Upload Modal: Persist view configuration (WordPress/gutenberg#77288) - Image block: Validate attachment ID exists before treating image as local (WordPress/gutenberg#77178) - Tabs: remove sequential numbering from new tab labels (WordPress/gutenberg#77321) - DataViews: Use `--wpds-cursor-control` design token for interactive controls (WordPress/gutenberg#77259) - Post Editor: Store metaboxes RTC-compatible flag on location entries (WordPress/gutenberg#77361) - Guidelines CPT: Skip registration when post type already exists (WordPress/gutenberg#77486) - RTC: Fixed orphaned meta causing dirty editor state (WordPress/gutenberg#77529) - Guidelines: Make the CPT type-aware (WordPress/gutenberg#77491) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65557. git-svn-id: https://develop.svn.wordpress.org/trunk@62580 602fd350-edb4-49c9-b593-d223f7449a82
What?
Part of #76135
Closes #76570
Adds a shared, unlayered CSS module (
global-css-defense.module.css) that shields@wordpress/uicomponents from wp-admin's global stylesheets (common.css,forms.css), and wires it into all currently affected components.Why?
@wordpress/uiplaces all component styles in CSS cascade layers. Per the spec, unlayered styles always win over layered styles regardless of specificity. Since wp-admin's global stylesheets are unlayered, they unconditionally override component styles — breaking borders, outlines, colors, focus rings, typography, and more.This is a blocker for using
@wordpress/uiin Gutenberg. While the problem itself is better addressed upstream, waiting for these changes to land in a WP release is going to be too slow for plugin developers to start adoption of@wordpress/ui. These plugins usually want to support at least two latest versions of WP, so that means they won't be able to use@wordpress/uifor another 6–12 months.The solution proposed in this PR is pretty much the only solution I could come up with that unblocks us immediately, is reasonably manageable, and is easy to remove once upstream improvements make the workarounds unnecessary.
How?
The defense module provides per-element classes (
.input,.textarea,.button,.div,.p,.heading,.a) that are applied directly to the elements that need protection. Each class is unlayered, so it competes with admin CSS on equal footing and wins by specificity.Properties are declared via a custom property bridge pattern:
@wordpress/ui, so most components need zero overrides.Testing Instructions
npm run storybook:dev) and enable the WordPress global CSS mode via the toolbar.Use of AI Tools
Cursor with Claude was used to author this PR.