Skip to content

Update test to use non-AVIF format since now supported in 6.5-alpha - #967

Merged
westonruter merged 1 commit into
trunkfrom
fix/tests-for-wp65
Feb 2, 2024
Merged

Update test to use non-AVIF format since now supported in 6.5-alpha#967
westonruter merged 1 commit into
trunkfrom
fix/tests-for-wp65

Conversation

@westonruter

@westonruter westonruter commented Feb 2, 2024

Copy link
Copy Markdown
Member

Now that AVIF support just landed in WP trunk via Core-51228, we need to use a different image format to check for an invalid MIME type. This fixes a unit test failure on 6.5-alpha.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@westonruter westonruter added [Type] Bug An existing feature is broken [Focus] Images [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) no milestone PRs that do not have a defined milestone for release labels Feb 2, 2024
@github-actions

github-actions Bot commented Feb 2, 2024

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: westonruter, adamsilverstein, joemcgill.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter changed the title Update test to use non-AVIF format since now supported Update test to use non-AVIF format since now supported in 6.5-alpha Feb 2, 2024

@adamsilverstein adamsilverstein left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've never seen a .pcx file (but that is the point I guess)

@westonruter

westonruter commented Feb 2, 2024

Copy link
Copy Markdown
Member Author

Looks good! I've never seen a .pcx file (but that is the point I guess)

I used the PCX format a lot with PC Paintbrush as a kid 😄

@joemcgill joemcgill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works.

@westonruter
westonruter merged commit 9cc0c2f into trunk Feb 2, 2024
@westonruter
westonruter deleted the fix/tests-for-wp65 branch February 2, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no milestone PRs that do not have a defined milestone for release [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants