Add Check_Runner interface - #70
Merged
Merged
Conversation
2 tasks
jjgrainger
requested changes
Feb 1, 2023
jjgrainger
left a comment
jjgrainger
left a comment
Contributor
There was a problem hiding this comment.
Thanks @vishalkakadiya great work, just some minor changes to make to the docblock and then should be good to go.
Co-authored-by: Joe Grainger <904708+jjgrainger@users.noreply.github.com>
Co-authored-by: Joe Grainger <904708+jjgrainger@users.noreply.github.com>
felixarntz
reviewed
Feb 1, 2023
felixarntz
left a comment
felixarntz
left a comment
Member
There was a problem hiding this comment.
Thanks @vishalkakadiya. Overall looks good, just some small nit-picks of feedback.
Author
|
@felixarntz @jjgrainger I have addressed your feedback. Thank you! 🙂 |
felixarntz
approved these changes
Feb 2, 2023
felixarntz
left a comment
felixarntz
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks @vishalkakadiya!
jjgrainger
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Force_Single_Plugin_Preparation class
Closes #13