e2e tests: Fix E2E selectors for WordPress trunk list tables - #529
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update the E2E row-checkbox selectors to work with both the
<th>markup used by released WordPress versions and the<td>markup now used by WordPress trunk.Why
WordPress Core changed list-table checkbox cells from
<th>to<td>in ae5d691. The existing element-specific selector no longer finds those checkboxes on trunk, which breaks cleanup and allows retries to accumulate duplicate records.Testing Instructions
git diff --checknpx wp-scripts lint-js tests/e2e/import-export.spec.ts tests/e2e/options-page-admin.spec.ts tests/e2e/post-type-admin.spec.tsUse of AI Tools
I used OpenAI Codex to update the selectors. I reviewed the diff and test results.