Reports: Align the meetup details export guard with sibling reports - #1834
Merged
Conversation
`Meetup_Details::export_to_file()` joined its nonce and capability checks with `&&`, so the two conditions were not both required. The other report classes use `||`; this matches them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meetup_Details::export_to_file()combined its nonce and capability checks with&&, so the early-return guard did not require both conditions to hold. Every other report class in the plugin writes this guard so that both a validrun-reportnonce and theview_wordcamp_reportscapability are required — seeclass-meetup-events.php,class-meetup-sponsors.php, andclass-wordcamp-details.php. This makesMeetup_Detailsconsistent with them.How to test the changes in this Pull Request:
view_wordcamp_reportscapability, open the Meetup Details report and export the CSV — it downloads as before.🤖 Generated with Claude Code