Consume latest toolkit and fix dangling promise bug - #1217

chkimes · 2023-08-07T18:39:19Z

This PR updates to the latest actions/cache version published from the toolkit, which contains actions/toolkit#1484 and should fix #810.

Description

See actions/toolkit#1484 for details on the Azure blob fixes. The cache action contains an additional fix for dangling promises that prevents the process from ending despite the cache being fully restored.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation (add or update README or docs)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

…ions-cache into upstream-cache

chkimes · 2023-08-08T17:46:20Z

-    await restoreImpl(new StateProvider());
-}
-
-run();


This caused a lot of problems in tests - the file was exporting and executing the run function, which feels like an unusual pattern. I moved this into restoreImpl and just reference it here directly, which required a bunch of non-functional test reactions.

kgrzebien

LGTM

bbrzoska · 2023-08-17T18:45:07Z

Hey @cwille97, any chance this fix can get released/tagged anytime soon? 🙏

Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/releases">actions/cache's releases</a>.</em></p> <blockquote> <h2>v4.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update action to node20 by <a href="https://github.com/takost"><code>@takost</code></a> in <a href="h ttps://redirect.github.com/actions/cache/pull/1284">actions/cache#1284</ a></li> <li>feat: save-always flag by <a href="https://github.com/to-s"><code>@to-s</code></a> in <a href="https ://redirect.github.com/actions/cache/pull/1242">actions/cache#1242</a></ li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/takost"><code>@takost</code></a> made their first contribution in <a href="https://redirect.github.com/actions /cache/pull/1284">actions/cache#1284</a></li> <li><a href="https://github.com/to-s"><code>@to-s</code></a> made their first contribution in <a href="https://redirect.github.com/actions/cache sagemath/pull/1242">actions/cache#1242</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/ cache/compare/v3...v4.0.0">https://github.com/actions/cache/compare/v3.. .v4.0.0</a></p> <h2>v3.3.3</h2> <h2>What's Changed</h2> <ul> <li>Cache v3.3.3 by <a href="https://github.com/robherley"><code>@robherley</code></a> in <a h ref="https://redirect.github.com/actions/cache/pull/1302">actions/cache# 1302</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/robherley"><code>@robherley</code></a> made their first contribution in <a href="https://redirect.github.com/ac tions/cache/pull/1302">actions/cache#1302</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/ cache/compare/v3...v3.3.3">https://github.com/actions/cache/compare/v3.. .v3.3.3</a></p> <h2>v3.3.2</h2> <h2>What's Changed</h2> <ul> <li>Fixed readme with new segment timeout values by <a href="https://github.com/kotewar"><code>@kotewar</code></a> in <a href= "https://redirect.github.com/actions/cache/pull/1133">actions/cache#1133 </a></li> <li>Readme fixes by <a href="https://github.com/kotewar"><code>@kotewar</code></a> in <a href= "https://redirect.github.com/actions/cache/pull/1134">actions/cache#1134 </a></li> <li>Updated description of the lookup-only input for main action by <a href="https://github.com/kotewar"><code>@kotewar</code></a> in <a href= "https://redirect.github.com/actions/cache/pull/1130">actions/cache#1130 </a></li> <li>Change two new actions mention as quoted text by <a href="https://github.com/bishal-pdMSFT"><code>@bishal-pdMSFT</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1131">actions /cache#1131</a></li> <li>Update Cross-OS Caching tips by <a href="https://github.com/pdotl"><code>@pdotl</code></a> in <a href="htt ps://redirect.github.com/actions/cache/pull/1122">actions/cache#1122</a> </li> <li>Bazel example (Take <a href="https://redirect.github.com/actions/cache/issues/2">#2</a>️⃣) by <a href="https://github.com/vorburger"><code>@vorburger</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1132">actions/ca che#1132</a></li> <li>Remove actions to add new PRs and issues to a project board by <a href="https://github.com/jorendorff"><code>@jorendorff</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1187">actions/cache sagemath#1187</a></li> <li>Consume latest toolkit and fix dangling promise bug by <a href="https://github.com/chkimes"><code>@chkimes</code></a> in <a href= "https://redirect.github.com/actions/cache/pull/1217">actions/cache#1217 </a></li> <li>Bump action version to 3.3.2 by <a href="https://github.com/bethanyj28"><code>@bethanyj28</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1236">actions/cache sagemath#1236</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/vorburger"><code>@vorburger</code></a> made their first contribution in <a href="https://redirect.github.com/ac tions/cache/pull/1132">actions/cache#1132</a></li> <li><a href="https://github.com/jorendorff"><code>@jorendorff</code></a> made their first contribution in <a href="https://redirect.github.com/actions /cache/pull/1187">actions/cache#1187</a></li> <li><a href="https://github.com/chkimes"><code>@chkimes</code></a> made their first contribution in <a href="https://redirect.github.com/actions /cache/pull/1217">actions/cache#1217</a></li> <li><a href="https://github.com/bethanyj28"><code>@bethanyj28</code></a> made their first contribution in <a href="https://redirect.github.com/actions /cache/pull/1236">actions/cache#1236</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/ cache/compare/v3...v3.3.2">https://github.com/actions/cache/compare/v3.. .v3.3.2</a></p> <h2>v3.3.1</h2> <h2>What's Changed</h2> <ul> <li>Reduced download segment size to 128 MB and timeout to 10 minutes by <a href="https://github.com/kotewar"><code>@kotewar</code></a> in <a hr ef="https://redirect.github.com/actions/cache/pull/1129">actions/cache#1 129</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/ cache/compare/v3...v3.3.1">https://github.com/actions/cache/compare/v3.. .v3.3.1</a></p> <h2>v3.3.0</h2> <h2>What's Changed</h2> <ul> <li>Bug: Permission is missing in cache delete example by <a href="https://github.com/kotokaze"><code>@kotokaze</code></a> in <a hre f="https://redirect.github.com/actions/cache/pull/1123">actions/cache#11 23</a></li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/blob/main/ RELEASES.md">actions/cache's changelog</a>.</em></p> <blockquote> <h1>Releases</h1> <h3>3.0.0</h3> <ul> <li>Updated minimum runner version support from node 12 -> node 16</li> </ul> <h3>3.0.1</h3> <ul> <li>Added support for caching from GHES 3.5.</li> <li>Fixed download issue for files > 2GB during restore.</li> </ul> <h3>3.0.2</h3> <ul> <li>Added support for dynamic cache size cap on GHES.</li> </ul> <h3>3.0.3</h3> <ul> <li>Fixed avoiding empty cache save when no files are available for caching. (<a href="https://redirect.github.com/actions/cache/issues/624" >issue</a>)</li> </ul> <h3>3.0.4</h3> <ul> <li>Fixed tar creation error while trying to create tar with path as <code>~/</code> home folder on <code>ubuntu-latest</code>. (<a href="htt ps://redirect.github.com/actions/cache/issues/689">issue</a>)</li> </ul> <h3>3.0.5</h3> <ul> <li>Removed error handling by consuming actions/cache 3.0 toolkit, Now cache server error handling will be done by toolkit. (<a href="https://redirect.github.com/actions/cache/pull/834">PR</a>)</li> </ul> <h3>3.0.6</h3> <ul> <li>Fixed <a href="https://redirect.github.com/actions/cache/issues/809">#809</a> - zstd -d: no such file or directory error</li> <li>Fixed <a href="https://redirect.github.com/actions/cache/issues/833">#833</a> - cache doesn't work with github workspace directory</li> </ul> <h3>3.0.7</h3> <ul> <li>Fixed <a href="https://redirect.github.com/actions/cache/issues/810">#810</a> - download stuck issue. A new timeout is introduced in the download process to abort the download if it gets stuck and doesn't finish within an hour.</li> </ul> <h3>3.0.8</h3> <ul> <li>Fix zstd not working for windows on gnu tar in issues <a href="https://redirect.github.com/actions/cache/issues/888">#888</a> and <a href="https://redirect.github.com/actions/cache/issues/891">#891</a>. </li> <li>Allowing users to provide a custom timeout as input for aborting download of a cache segment using an environment variable <code>SEGMENT_DOWNLOAD_TIMEOUT_MINS</code>. Default is 60 minutes.</li> </ul> <h3>3.0.9</h3> <ul> <li>Enhanced the warning message for cache unavailablity in case of GHES.</li> </ul> <h3>3.0.10</h3> <ul> <li>Fix a bug with sorting inputs.</li> <li>Update definition for restore-keys in README.md</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="actions/cache@13aacd865c20de90d75 de3b17ebe84f7a17d57d2"><code>13aacd8</code></a> Merge pull request <a href="https://redirect.github.com/actions/cache/issues/1242">#1242</a> from to-s/main</li> <li><a href="actions/cache@53b35c543921fe2e8b2 88765ff817de9de8d906f"><code>53b35c5</code></a> Merge branch 'main' into main</li> <li><a href="actions/cache@65b8989fab3bb394817 bdb845a453dff480c2b51"><code>65b8989</code></a> Merge pull request <a href="https://redirect.github.com/actions/cache/issues/1284">#1284</a> from takost/update-to-node-20</li> <li><a href="actions/cache@d0be34d54485f31ca2c cbe66e6ea3d96544a807b"><code>d0be34d</code></a> Fix dist</li> <li><a href="actions/cache@66cf064d47313d2cccf 392d01bd10925da2bd072"><code>66cf064</code></a> Merge branch 'main' into update-to-node-20</li> <li><a href="actions/cache@1326563738ddb735c5f 2ce85cba8c79f33b728cd"><code>1326563</code></a> Merge branch 'main' into main</li> <li><a href="actions/cache@e71876755e268d6cc25 a5d3e3c46ae447e35290a"><code>e718767</code></a> Fix format</li> <li><a href="actions/cache@01229828ffa049a8dee 4db27bcb23ed33f2b451f"><code>0122982</code></a> Apply workaround for earlyExit</li> <li><a href="actions/cache@3185ecfd6135856ca6d 904ae032cff4f39b8b365"><code>3185ecf</code></a> Update "only-" actions to node20</li> <li><a href="actions/cache@25618a0a675e8447e5f fc8ed9b7ddb2aaf927f65"><code>25618a0</code></a> Bump version</li> <li>Additional commits viewable in <a href="https://github.com/actions/cache/compare/v3...v4">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot- badges.githubapp.com/badges/compatibility_score?dependency- name=actions/cache&package-manager=github_actions&previous- version=3&new-version=4)](https://docs.github.com/en/github/managing- security-vulnerabilities/about-dependabot-security-updates#about- compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. URL: sagemath#37474 Reported by: dependabot[bot] Reviewer(s):

* Consume latest toolkit and fix dangling promise bug * Pass earlyExit parameter to run method so tests don't hang * Pass earlyExit parameter to run method so tests don't hang * Refactor restore files to have better patterns for testing * style

sagemathgh-37474: ⬆️ Bump actions/cache from 3 to 4 Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/releases">actions/cache's releases</a>.</em></p> <blockquote> <h2>v4.0.0</h2> <h2>What's Changed</h2> <ul> <li>Update action to node20 by <a href="https://github.com/takost"><code>@takost</code></a> in <a href="h ttps://redirect.github.com/actions/cache/pull/1284">actions/cache#1284</ a></li> <li>feat: save-always flag by <a href="https://github.com/to-s"><code>@to-s</code></a> in <a href="https ://redirect.github.com/actions/cache/pull/1242">actions/cache#1242</a></ li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/takost"><code>@takost</code></a> made their first contribution in <a href="https://redirect.github.com/actions /cache/pull/1284">actions/cache#1284</a></li> <li><a href="https://github.com/to-s"><code>@to-s</code></a> made their first contribution in <a href="https://redirect.github.com/actions/cache sagemath/pull/1242">actions/cache#1242</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/ cache/compare/v3...v4.0.0">https://github.com/actions/cache/compare/v3.. .v4.0.0</a></p> <h2>v3.3.3</h2> <h2>What's Changed</h2> <ul> <li>Cache v3.3.3 by <a href="https://github.com/robherley"><code>@robherley</code></a> in <a h ref="https://redirect.github.com/actions/cache/pull/1302">actions/cache# 1302</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/robherley"><code>@robherley</code></a> made their first contribution in <a href="https://redirect.github.com/ac tions/cache/pull/1302">actions/cache#1302</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/ cache/compare/v3...v3.3.3">https://github.com/actions/cache/compare/v3.. .v3.3.3</a></p> <h2>v3.3.2</h2> <h2>What's Changed</h2> <ul> <li>Fixed readme with new segment timeout values by <a href="https://github.com/kotewar"><code>@kotewar</code></a> in <a href= "https://redirect.github.com/actions/cache/pull/1133">actions/cache#1133 </a></li> <li>Readme fixes by <a href="https://github.com/kotewar"><code>@kotewar</code></a> in <a href= "https://redirect.github.com/actions/cache/pull/1134">actions/cache#1134 </a></li> <li>Updated description of the lookup-only input for main action by <a href="https://github.com/kotewar"><code>@kotewar</code></a> in <a href= "https://redirect.github.com/actions/cache/pull/1130">actions/cache#1130 </a></li> <li>Change two new actions mention as quoted text by <a href="https://github.com/bishal-pdMSFT"><code>@bishal-pdMSFT</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1131">actions /cache#1131</a></li> <li>Update Cross-OS Caching tips by <a href="https://github.com/pdotl"><code>@pdotl</code></a> in <a href="htt ps://redirect.github.com/actions/cache/pull/1122">actions/cache#1122</a> </li> <li>Bazel example (Take <a href="https://redirect.github.com/actions/cache/issues/2">#2</a>️⃣) by <a href="https://github.com/vorburger"><code>@vorburger</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1132">actions/ca che#1132</a></li> <li>Remove actions to add new PRs and issues to a project board by <a href="https://github.com/jorendorff"><code>@jorendorff</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1187">actions/cache sagemath#1187</a></li> <li>Consume latest toolkit and fix dangling promise bug by <a href="https://github.com/chkimes"><code>@chkimes</code></a> in <a href= "https://redirect.github.com/actions/cache/pull/1217">actions/cache#1217 </a></li> <li>Bump action version to 3.3.2 by <a href="https://github.com/bethanyj28"><code>@bethanyj28</code></a> in <a href="https://redirect.github.com/actions/cache/pull/1236">actions/cache sagemath#1236</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/vorburger"><code>@vorburger</code></a> made their first contribution in <a href="https://redirect.github.com/ac tions/cache/pull/1132">actions/cache#1132</a></li> <li><a href="https://github.com/jorendorff"><code>@jorendorff</code></a> made their first contribution in <a href="https://redirect.github.com/actions /cache/pull/1187">actions/cache#1187</a></li> <li><a href="https://github.com/chkimes"><code>@chkimes</code></a> made their first contribution in <a href="https://redirect.github.com/actions /cache/pull/1217">actions/cache#1217</a></li> <li><a href="https://github.com/bethanyj28"><code>@bethanyj28</code></a> made their first contribution in <a href="https://redirect.github.com/actions /cache/pull/1236">actions/cache#1236</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/ cache/compare/v3...v3.3.2">https://github.com/actions/cache/compare/v3.. .v3.3.2</a></p> <h2>v3.3.1</h2> <h2>What's Changed</h2> <ul> <li>Reduced download segment size to 128 MB and timeout to 10 minutes by <a href="https://github.com/kotewar"><code>@kotewar</code></a> in <a hr ef="https://redirect.github.com/actions/cache/pull/1129">actions/cache#1 129</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/ cache/compare/v3...v3.3.1">https://github.com/actions/cache/compare/v3.. .v3.3.1</a></p> <h2>v3.3.0</h2> <h2>What's Changed</h2> <ul> <li>Bug: Permission is missing in cache delete example by <a href="https://github.com/kotokaze"><code>@kotokaze</code></a> in <a hre f="https://redirect.github.com/actions/cache/pull/1123">actions/cache#11 23</a></li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/blob/main/ RELEASES.md">actions/cache's changelog</a>.</em></p> <blockquote> <h1>Releases</h1> <h3>3.0.0</h3> <ul> <li>Updated minimum runner version support from node 12 -> node 16</li> </ul> <h3>3.0.1</h3> <ul> <li>Added support for caching from GHES 3.5.</li> <li>Fixed download issue for files > 2GB during restore.</li> </ul> <h3>3.0.2</h3> <ul> <li>Added support for dynamic cache size cap on GHES.</li> </ul> <h3>3.0.3</h3> <ul> <li>Fixed avoiding empty cache save when no files are available for caching. (<a href="https://redirect.github.com/actions/cache/issues/624" >issue</a>)</li> </ul> <h3>3.0.4</h3> <ul> <li>Fixed tar creation error while trying to create tar with path as <code>~/</code> home folder on <code>ubuntu-latest</code>. (<a href="htt ps://redirect.github.com/actions/cache/issues/689">issue</a>)</li> </ul> <h3>3.0.5</h3> <ul> <li>Removed error handling by consuming actions/cache 3.0 toolkit, Now cache server error handling will be done by toolkit. (<a href="https://redirect.github.com/actions/cache/pull/834">PR</a>)</li> </ul> <h3>3.0.6</h3> <ul> <li>Fixed <a href="https://redirect.github.com/actions/cache/issues/809">#809</a> - zstd -d: no such file or directory error</li> <li>Fixed <a href="https://redirect.github.com/actions/cache/issues/833">#833</a> - cache doesn't work with github workspace directory</li> </ul> <h3>3.0.7</h3> <ul> <li>Fixed <a href="https://redirect.github.com/actions/cache/issues/810">#810</a> - download stuck issue. A new timeout is introduced in the download process to abort the download if it gets stuck and doesn't finish within an hour.</li> </ul> <h3>3.0.8</h3> <ul> <li>Fix zstd not working for windows on gnu tar in issues <a href="https://redirect.github.com/actions/cache/issues/888">#888</a> and <a href="https://redirect.github.com/actions/cache/issues/891">#891</a>. </li> <li>Allowing users to provide a custom timeout as input for aborting download of a cache segment using an environment variable <code>SEGMENT_DOWNLOAD_TIMEOUT_MINS</code>. Default is 60 minutes.</li> </ul> <h3>3.0.9</h3> <ul> <li>Enhanced the warning message for cache unavailablity in case of GHES.</li> </ul> <h3>3.0.10</h3> <ul> <li>Fix a bug with sorting inputs.</li> <li>Update definition for restore-keys in README.md</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="actions/cache@13aacd865c20de90d75 de3b17ebe84f7a17d57d2"><code>13aacd8</code></a> Merge pull request <a href="https://redirect.github.com/actions/cache/issues/1242">#1242</a> from to-s/main</li> <li><a href="actions/cache@53b35c543921fe2e8b2 88765ff817de9de8d906f"><code>53b35c5</code></a> Merge branch 'main' into main</li> <li><a href="actions/cache@65b8989fab3bb394817 bdb845a453dff480c2b51"><code>65b8989</code></a> Merge pull request <a href="https://redirect.github.com/actions/cache/issues/1284">#1284</a> from takost/update-to-node-20</li> <li><a href="actions/cache@d0be34d54485f31ca2c cbe66e6ea3d96544a807b"><code>d0be34d</code></a> Fix dist</li> <li><a href="actions/cache@66cf064d47313d2cccf 392d01bd10925da2bd072"><code>66cf064</code></a> Merge branch 'main' into update-to-node-20</li> <li><a href="actions/cache@1326563738ddb735c5f 2ce85cba8c79f33b728cd"><code>1326563</code></a> Merge branch 'main' into main</li> <li><a href="actions/cache@e71876755e268d6cc25 a5d3e3c46ae447e35290a"><code>e718767</code></a> Fix format</li> <li><a href="actions/cache@01229828ffa049a8dee 4db27bcb23ed33f2b451f"><code>0122982</code></a> Apply workaround for earlyExit</li> <li><a href="actions/cache@3185ecfd6135856ca6d 904ae032cff4f39b8b365"><code>3185ecf</code></a> Update "only-" actions to node20</li> <li><a href="actions/cache@25618a0a675e8447e5f fc8ed9b7ddb2aaf927f65"><code>25618a0</code></a> Bump version</li> <li>Additional commits viewable in <a href="https://github.com/actions/cache/compare/v3...v4">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot- badges.githubapp.com/badges/compatibility_score?dependency- name=actions/cache&package-manager=github_actions&previous- version=3&new-version=4)](https://docs.github.com/en/github/managing- security-vulnerabilities/about-dependabot-security-updates#about- compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. URL: sagemath#37474 Reported by: dependabot[bot] Reviewer(s):

Copied from actions/cache#1217

@v4

…ncy (#1) * 3.2.6 * Bump @actions/cache version * Update package-lock.json * Fix zstd breaking after new version release * Fix license * Update Cross-OS Caching tips * docs: Add missing permission in cache delete example (actions#1123) * Add `lookup-only` option (actions#1041) * Add new actions/cache version (with dryRun support) * Add dry-run option * Changes after rebase * Update readme * Rename option to lookup-only * Update test name * Update package.json + changelog * Update README * Update custom package version * Update custom package version * Update @actions/cache to 3.2.0 * Code review * Update log statement * Move test case --------- Co-authored-by: Sankalp Kotewar <98868223+kotewar@users.noreply.github.com> * Change two new actions mention as quoted text * Add example for Bazel * Fix example for Bazel * Reduced download segment size to 128 MB and timeout to 10 minutes (actions#1129) * Changed segment size to 128mb & timeout to 10 min * Updated license * Updated licenses * Fixed readme with new segment timeout values (actions#1133) * Readme fixes (actions#1134) * Update README.md * Update README.md * Create separate Linux/macOS examples for Bazel * Updated description of the lookup-only input for main action (actions#1130) * Updated description of the lookup-only input for main action * Update README.md Co-authored-by: Bishal Prasad <bishal-pdmsft@github.com> * Update README.md --------- Co-authored-by: Bishal Prasad <bishal-pdmsft@github.com> * Clarify that macos-latest image has bazelisk * Remove actions to add new PRs and issues to a project board The project doesn't seem to exist, so this always fails. * Consume latest toolkit and fix dangling promise bug (actions#1217) * Consume latest toolkit and fix dangling promise bug * Pass earlyExit parameter to run method so tests don't hang * Pass earlyExit parameter to run method so tests don't hang * Refactor restore files to have better patterns for testing * style * bump action version to 3.3.2 * Add to RELEASES.md * added save-always input * Update action.yml Co-authored-by: Tomasz Janiszewski <janiszt@gmail.com> * Revert "Update action.yml" This reverts commit 3b7dac1. * Update action to node20 * Update check-dist node version * Rebuild dist * Update license * replace deprecated @zeit/ncc with @vercel/ncc * Bump version * Update "only-" actions to node20 * Apply workaround for earlyExit * Fix format * cache v3.3.3 * licensed * Fix dist * Update README.md * Update examples * update documentation to use <action>@v4 * add release action * update @actions/cache * licensed cache * Fix fail-on-cache-miss not working * Bump version * Add test case for process exit Co-authored-by: Bethany <bethanyj28@users.noreply.github.com> * Update README.md and use v4 of checkout action (actions#1437) Update examples to use latest available checkout action v4. * Explicit use bash for Windows (actions#1377) Co-authored-by: Josh Gross <joshmgross@github.com> * Fix cache-hit output when cache missed (actions#1404) * fix: cache-hit output * fix: Output chache hit timing * fix: Output chache hit timing --------- Co-authored-by: Josh Gross <joshmgross@github.com> * Clarify that the `restore-keys` input is a string in the docs (actions#1434) * Fix Description for restore-keys at Readme As previously the restore-keys were defined as an ordered lists which is wrong as per the issue description where the actual format is a multi-line string with one key per line. * Added a space between the sentence of restore-keys description While at the PR review it's been identified there's a need for a space between the sentence ``` An ordered multiline string listing the prefix-matched keys,that are used for restoring stale cache if no cache hit occurred for key. ``` where it's written as "prefix-matched keys,that are" this commit will address the review comment and introduce a space between "prefix-matched keys, that are" and change the sentence to ``` An ordered multiline string listing the prefix-matched keys, that are used for restoring stale cache if no cache hit occurred for key. ``` * Change restore-keys description at cache/restore/action.yml and cache/action.yml * Add workflow file for publishing releases to immutable action package This workflow file publishes new action releases to the immutable action package of the same name as this repo. This is part of the Immutable Actions project which is not yet fully released to the public. First party actions like this one are part of our initial testing of this feature. * Deprecate `save-always` input (actions#1452) The `save-always` input added in v4 is not working as intended due to `post-if` expressions not supporting the input context. To avoid breaking users who have already added this input to their workflows, it is being deprecated now and will be removed in the next major version (v5). See actions#1315 for more details. * Fix typo: depening -> depending (actions#1462) Co-authored-by: Josh Gross <joshmgross@github.com> * restore action's README now references v4 instead of v3 (actions#1445) Co-authored-by: Josh Gross <joshmgross@github.com> * Prepare `4.1.0` release (actions#1464) * Restore original behavior of `cache-hit` output (actions#1467) * Restore original behavior of `cache-hit` output * Bump version to 4.1.1 * Add Bun example (actions#1456) * Add Bun example * Fix Bun Windows example * Revise `isGhes` logic * ran `npm run build` * appease the linter * added unit tests * Bump braces from 3.0.2 to 3.0.3 Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Create dependabot.yml * Prepare release 4.1.2 * Bump actions/checkout from 3 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/stale from 3 to 9 Bumps [actions/stale](https://github.com/actions/stale) from 3 to 9. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v3...v9) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/setup-node from 3 to 4 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github/codeql-action from 2 to 3 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v2...v3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Upgrade @actions/cache to 4.0.0 * Update RELEASES.md * Upgrade @vercel/ncc to 0.38.3 * Upgrade @actions/core to 1.11.1 and other deps * Add licensed output * Add reviewed licensed packages * Add lodash to list of reviewed licenses * Add licensed output * Rerun CI * Add 3.4.0 release notes * Correct GitHub Spelling in caching-strategies.md (actions#1526) GitHub was spelled incorrectly 3 lines under the Understanding how to choose path section * docs: Make the "always save prime numbers" example more clear (actions#1525) * Update force deletion docs due a recent deprecation (actions#1500) * fix: update force deletion docs due a recent deprecation * fix: applied josh's suggestions --------- Co-authored-by: Josh Gross <joshmgross@github.com> * bump @actions/cache to v4.0.1 * Update publish-immutable-actions.yml * bump @actions/cache to v4.0.2, prep for v4.2.2 release * add changes * changed * mask whole url * debugging * type * artifact changes * update cache package to mask whole sas to the end of the line * mask * update * latest test before pr * updated cache with latest changes * updates * new package * update cache with main * Update to use the latest version of the cache package to obfuscate the SAS * Update releases.md * Update README.md * update to node24 * update licences * @protobuf-ts/plugin to dev dependencies * Add licensed output * Add licensed output * Update the licensed workflow to use the latest version * Fix the workflow to use licensed from source * Fix bundle exec * Fix with another approach * Prepare release 4.2.4 * Add note on runner versions * license and compiled * Approve license * Upgrade actions/cache to 4.1.0 and prepare 4.3.0 release * Update licensed cache * Update cache to use local cache package and Node 24 support - Use local cache package with file:../packages/cache instead of published version - Update all action.yml files to use node24 runtime - Update dependencies to support Node 24 (@types/node@24.1.0) - Rebuild dist files with local cache package - Add engines field requiring node >=24 * Build dist files for Node 24 * chore: rebuild dist with local @actions/cache (core v2, exec v2) * chore: use local @actions/core, exec, io packages * Build with @actions/cache v5.0.0 * Use published @actions/core, exec, io v2.0.0 * chore: rebuild with @actions/cache v5.0.0 Uses updated cache package that removes @azure/ms-rest-js dependency to fix Node 24 punycode deprecation warning. * Update with core 2.0.1 which has exec 2.0.0 * chore: update @actions/core to 2.0.1 * Latest dist with core changes * Extra dist change * chore: use published @actions/cache v5.0.0 * chore: update license cache for @actions/cache v5.0.0 * chore: rebuild dist with @actions/cache v5.0.0 * chore: update actions/checkout to v5 in workflow files * chore: bump version to 5.0.0 for Node.js 24 support * docs: update README with v5 release notes * Revert "docs: update README with v5 release notes" This reverts commit fe92eaf. * chore: revert README to main branch state * chore: set version to 4.3.0 for prepare release PR * chore: rebuild dist with version 4.3.0 * chore: regenerate package-lock.json * undo readme changes * Prepare v5.0.0 release - Bump package version to 5.0.0 - Add v5.0.0 release notes (Node.js 24 runtime + runner requirement) * docs: update README for v5 release with Node 24 and runner version requirements * readme note * docs: highlight v5 runner requirement in releases * fix: update @actions/cache with storage-blob fix for Node.js 24 punycode deprecation * peer * fix: update @actions/cache to ^5.0.1 for Node.js 24 punycode fix Updates @actions/cache to version 5.0.1 which includes the @azure/storage-blob update that fixes the punycode deprecation warning on Node.js 24. * fix: update license files for @actions/cache, fast-xml-parser, and strnum * fix: add peer property to package-lock.json for dependencies * chore: release v5.0.1 - Bump version to 5.0.1 - Fix Node.js 24 punycode deprecation warning via @actions/cache@5.0.1 - Updates @azure/storage-blob to ^12.29.1 Related: actions#1685 * docs: Update examples to cache@v5 * docs: Update other actions in examples to the latest version * Bump actions/cache to 5.0.3 * Add PR link to releases * Build * Update licensed record for cache * license for httpclient * Add 5.0.3 builds * Upgrade dependencies and address security warnings - Bump `@actions/cache` to v5.0.5 - Bump `@actions/core` to v2.0.3 * Add licensed output * Add review for the @actions/http-client license * Update contribution docs * Add note * Potential fix for code scanning alert no. 52: Workflow does not contain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Fix permissions for workflows/workflow.yml * Fix workflow permissions and cleanup * Cleanup workflow file names * Update .github/workflows/pr-opened-workflow.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Rewrite and simplify * Add wait for proxy * Fix resolution * Add traffic sanity check step * Fix cache key in examples.md for bun.lock Updated cache key to use 'bun.lock' instead of 'bun.lockb' for consistency. * Update dependencies & patch security vulnerabilities * Add licenses * Update RELEASES * Update ts-http-runtime to 0.3.5 * npm run build generated dist files * licensed changes --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Lovepreet Singh <pdotl@github.com> Co-authored-by: Kotokaze <62094392+kotokaze@users.noreply.github.com> Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> Co-authored-by: Sankalp Kotewar <98868223+kotewar@users.noreply.github.com> Co-authored-by: Bishal Prasad <bishal-pdmsft@github.com> Co-authored-by: David Bernard <davidB@users.noreply.github.com> Co-authored-by: Michael Vorburger <vorburger@google.com> Co-authored-by: Michael Vorburger ⛑️ <mike@vorburger.ch> Co-authored-by: Vipul <vsvipul@github.com> Co-authored-by: Jason Orendorff <jorendorff@github.com> Co-authored-by: Johanan Idicula <jidicula@github.com> Co-authored-by: Chad Kimes <1936066+chkimes@users.noreply.github.com> Co-authored-by: bethanyj28 <bethanyj28@github.com> Co-authored-by: Bethany <bethanyj28@users.noreply.github.com> Co-authored-by: to-s <26573402+to-s@users.noreply.github.com> Co-authored-by: Tomasz Janiszewski <janiszt@gmail.com> Co-authored-by: to-s <to-s@users.noreply.github.com> Co-authored-by: Tatyana Kostromskaya <32135588+takost@users.noreply.github.com> Co-authored-by: Rob Herley <robherley@github.com> Co-authored-by: Yang Cao <yacaovsnc@github.com> Co-authored-by: todgru <todgru@gmail.com> Co-authored-by: P. Ottlinger <ottlinger@users.noreply.github.com> Co-authored-by: Oleg A. <t0rr@mail.ru> Co-authored-by: Josh Gross <joshmgross@github.com> Co-authored-by: r4mimu <52129983+fchimpan@users.noreply.github.com> Co-authored-by: Soubhik Kumar Mitra <59209034+x612skm@users.noreply.github.com> Co-authored-by: Bassem Dghaidi <568794+Link-@users.noreply.github.com> Co-authored-by: Joel Ambass <Jcambass@users.noreply.github.com> Co-authored-by: mackey0225 <masaki.asano0225@gmail.com> Co-authored-by: Eman Resu <78693624+quatquatt@users.noreply.github.com> Co-authored-by: Jan T. Sott <git@idleberg.com> Co-authored-by: John Wesley Walker III <81404201+jww3@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: janco-absa <janco.bester@absa.africa> Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com> Co-authored-by: Alessandro Sebastiani <sebbalex@users.noreply.github.com> Co-authored-by: Salman Chishti <salmanmkc@GitHub.com> Co-authored-by: Ben De St Paer-Gotch <nebuk89@github.com> Co-authored-by: Ryan Ghadimi <114221941+GhadimiR@users.noreply.github.com> Co-authored-by: XZTDean <xztdean@gmail.com> Co-authored-by: Ryan Ghadimi <ghadimir@github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ryan Peck <1244954+RyPeck@users.noreply.github.com>

chkimes requested a review from a team as a code owner August 7, 2023 18:39

chkimes force-pushed the users/chkimes/upstream-cache branch from d05ddef to 568383d Compare August 7, 2023 18:58

Consume latest toolkit and fix dangling promise bug

a29b2ab

chkimes force-pushed the users/chkimes/upstream-cache branch from 568383d to a29b2ab Compare August 7, 2023 19:05

chkimes added 5 commits August 8, 2023 15:15

Pass earlyExit parameter to run method so tests don't hang

74148e1

Pass earlyExit parameter to run method so tests don't hang

866fe82

Merge branch 'users/chkimes/upstream-cache' of github.com:chkimes/act…

8032cbd

…ions-cache into upstream-cache

Refactor restore files to have better patterns for testing

d77303b

style

e3eed52

chkimes commented Aug 8, 2023

View reviewed changes

kgrzebien approved these changes Aug 8, 2023

View reviewed changes

cwille97 approved these changes Aug 8, 2023

View reviewed changes

kgrzebien merged commit f7ebb81 into actions:main Aug 9, 2023

djaglowski mentioned this pull request Aug 9, 2023

Pipelines: Step Cache Go takes too long open-telemetry/opentelemetry-collector-contrib#21506

Closed

bethanyj28 mentioned this pull request Sep 6, 2023

Bump action version to 3.3.2 #1236

Merged

10 tasks

Teddy-van-Jerry mentioned this pull request Sep 11, 2023

Bump actions/cache from 3.3.1 to 3.3.2 mmcesim/mmcesim#80

Merged

renovate Bot mentioned this pull request Sep 24, 2023

chore(deps): update all non-major dependencies (2.x) nuxt/nuxt#22820

Merged

1 task

NickLaMuro mentioned this pull request Nov 20, 2023

fail-on-cache-miss for restore action not failing the workflow #1265

Closed

This was referenced Jan 22, 2024

Bump actions/cache from 3 to 4 vrslev/jack_server#110

Merged

chore(deps): bump actions/cache from 3 to 4 vrslev/ikea-api-client#216

Merged

gucio321 mentioned this pull request Jan 22, 2024

build(deps): bump actions/cache from 3 to 4 gucio321/tic-tac-go#225

Merged

jamesmstone mentioned this pull request Jan 23, 2024

Bump actions/cache from 3 to 4 jamesmstone/parkrun#4

Merged

cdce8p mentioned this pull request Feb 15, 2024

Fix fail-on-cache-miss not working #1327

Merged

10 tasks

mweberxyz mentioned this pull request Apr 4, 2024

Leaked socket in cache/internal/cacheHttpClient actions/toolkit#1702

Open

carlosperate mentioned this pull request May 29, 2024

2 minute hang after install & caching carlosperate/arm-none-eabi-gcc-action#51

Closed

eifinger added a commit to astral-sh/setup-uv that referenced this pull request Nov 23, 2024

Add comment to clarify process.exit(0)

6a57cf3

Copied from actions/cache#1217

eifinger mentioned this pull request Nov 23, 2024

Add comment to clarify process.exit(0) astral-sh/setup-uv#161

Merged

eifinger added a commit to astral-sh/setup-uv that referenced this pull request Nov 23, 2024

Add comment to clarify process.exit(0) (#161)

9b71657

Copied from actions/cache#1217

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Consume latest toolkit and fix dangling promise bug - #1217