Fix caching when wrapper distributions are absent - #1151
Merged
brunoborges merged 4 commits intoJul 28, 2026
Merged
Conversation
Skip optional Maven and Gradle wrapper cache saves when their distribution paths do not exist, while allowing the main dependency cache to save. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a43181c5-548d-4293-be58-b76c03cece79
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses a caching failure in the post step when Maven/Gradle wrapper metadata exists but the wrapper distribution directory is absent, ensuring the main dependency cache can still be saved while skipping only the optional wrapper cache.
Changes:
- Add a pre-save path resolution/existence check for wrapper (additional) caches to avoid
@actions/cachepath validation errors. - Extend regression coverage to include Maven + Gradle scenarios where wrapper properties exist but wrapper distributions do not.
- Rebuild the generated
distbundles to include the fix.
Show a summary per file
| File | Description |
|---|---|
| src/cache.ts | Adds wrapper-cache path resolution/skip logic before calling saveCache. |
| tests/cache.test.ts | Adds/updates tests to ensure wrapper cache skips do not prevent saving the main cache. |
| dist/setup/index.js | Rebuilt bundle reflecting the updated wrapper-cache save behavior. |
| dist/cleanup/index.js | Rebuilt bundle reflecting the updated wrapper-cache save behavior. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/4 changed files
- Comments generated: 1
- Review effort level: Low
3 tasks
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a43181c5-548d-4293-be58-b76c03cece79
Regenerate the setup and cleanup bundles after updating additional cache saves to use resolved paths. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a43181c5-548d-4293-be58-b76c03cece79
brunoborges
added a commit
that referenced
this pull request
Jul 29, 2026
Skip optional Maven and Gradle wrapper cache saves when their distribution paths do not exist, while allowing the main dependency cache to save. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0b19ff2-ef52-4ac1-a832-0f8f72c43219
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Projects can keep Maven or Gradle wrapper metadata while intentionally using the system build tool, leaving the wrapper distribution directory absent. The post action now resolves optional wrapper-cache paths before calling
@actions/cache; when no path exists, it skips only that wrapper cache and continues saving the main dependency cache.Regression tests cover both Maven and Gradle and verify that the main cache is still saved. The generated setup and cleanup bundles are rebuilt with the fix.
Related issue:
Fixes: #1150
Check list:
npm run checklocally (format, lint, build, test) and all checks pass.