Deprecate legacy Adopt distributions in v5 - #1186
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0cd196f2-1044-4d33-96bb-8e794a00b03c
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The deprecation warning is correctly centralized, behavior is preserved, docs are updated consistently, and targeted tests were added for the new warning behavior.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR formalizes the deprecation of legacy AdoptOpenJDK distribution keywords in setup-java v5 while preserving their runtime behavior, and updates user-facing docs plus the bundled dist output accordingly.
Changes:
- Emit a deprecation warning when
adopt,adopt-hotspot, oradopt-openj9is selected, recommendingtemurin/semeru. - Remove the prior runtime notice from the Adopt installer path so the warning is centralized at distribution selection time.
- Update documentation/action metadata to mark Adopt keywords as deprecated and regenerate the bundled
distartifact.
File summaries
| File | Description |
|---|---|
| src/distributions/distribution-factory.ts | Adds centralized deprecation warning for legacy Adopt distribution keywords. |
| src/distributions/adopt/installer.ts | Removes legacy “moved to Temurin” notice to avoid duplicate/late messaging. |
| README.md | Marks legacy Adopt keywords as deprecated and updates guidance text. |
| docs/advanced-usage.md | Updates Adopt section note to reflect v5 deprecation / v6 removal guidance. |
| dist/setup/index.js | Regenerated bundled action output reflecting source changes. |
| action.yml | Updates distribution input description to mention Adopt deprecation/removal timeline. |
| tests/distributors/distribution-factory.test.ts | Adds coverage asserting warning + installer preservation for Adopt keywords. |
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adopt,adopt-hotspot, andadopt-openj9runtime supporttemurinorsemeruTesting
npm test -- --runInBandnpm run format-checknpm run lintnpm run build