nsh: Decouple with CONFIG_FILE_STREAM - #1559

no1wudi · 2023-02-10T09:52:25Z

Summary

Replace all fwrite/fread/fgets/... to write/read/... .

Before:

       text    data     bss     dec     hex filename
 109827     601    6608  117036   1c92c nuttx/nuttx

After:

       text    data     bss     dec     hex filename
108053     601    6608  115262   1c23e nuttx/nuttx

After with CONFIG_FILE_STREAM disabled:

       text    data     bss     dec     hex filename
 105667     601    6608  112876   1b8ec nuttx/nuttx

Impact

nsh

Testing

QEMU

xiaoxiang781216 · 2023-02-10T20:27:55Z

CI break is fixed by apache/nuttx#8498

no1wudi · 2023-02-16T05:53:21Z

Split to 2 PR (readline relative and nsh)

no1wudi · 2023-02-23T02:20:21Z

@masayuki2009 Which board/config used in your testing ? Could you check the CONFIG_TELNET_TXBUFFER_SIZE value ?

continue the change from apache#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

no1wudi · 2023-02-23T04:39:49Z

@masayuki2009 Which board/config used in your testing ? Could you check the CONFIG_TELNET_TXBUFFER_SIZE value ?

I've tested telnetd on esp32c3-devkit, and I can't reproduce this behavior on it.

masayuki2009 · 2023-02-23T05:16:46Z

@no1wudi
I’m on holiday today so I can not confirm the config now.
However, the above movies were based on spresense:wifi_smp

continue the change from apache#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

masayuki2009 · 2023-02-23T11:09:57Z

@no1wudi

Could you check the CONFIG_TELNET_TXBUFFER_SIZE value

$ grep -i CONFIG_TELNET_TX .config
CONFIG_TELNET_TXBUFFER_SIZE=256

continue the change from apache#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

masayuki2009 · 2023-02-23T22:58:23Z

@no1wudi

However, the above movies were based on spresense:wifi_smp

The same issue happens with spresense:rndis_smp too.

masayuki2009 · 2023-02-23T23:52:11Z

@no1wudi
The same issue also happens with rv-virt:netnsh_smp (qemu) on ubuntu 18.04 (x86_64)
However, the host PC is fast so the symptom is not worse than the spresense.

masayuki2009 · 2023-02-24T01:17:59Z

@no1wudi
As for esp32-devkitc, I found out how to reproduce the issue.
Please try wapi_smp without CONFIG_NET_TCP_WRITE_BUFFERS=y.
You would see the same symptom as spresense:wifi_smp
In this case (i.e. esp32-devkitc:wapi_smp without CONFIG_NET_TCP_WRITE_BUFFERS=y), reverting this PR would not cause the issue.

--- a/boards/xtensa/esp32/esp32-devkitc/configs/wapi_smp/defconfig
+++ b/boards/xtensa/esp32/esp32-devkitc/configs/wapi_smp/defconfig
@@ -67,7 +67,6 @@ CONFIG_NET_ICMP=y
 CONFIG_NET_ICMP_SOCKET=y
 CONFIG_NET_STATISTICS=y
 CONFIG_NET_TCP=y
-CONFIG_NET_TCP_WRITE_BUFFERS=y
 CONFIG_NET_UDP=y
 CONFIG_NFS=y
 CONFIG_NSH_ARCHINIT=y

no1wudi · 2023-02-24T01:26:28Z

@masayuki2009 Thanks for your information, I'll continue debug it.

no1wudi · 2023-02-24T01:38:18Z

@no1wudi As for esp32-devkitc, I found out how to reproduce the issue. Please try wapi_smp without CONFIG_NET_TCP_WRITE_BUFFERS=y. You would see the same symptom as spresense:wifi_smp In this case (i.e. esp32-devkitc:wapi_smp without CONFIG_NET_TCP_WRITE_BUFFERS=y), reverting this PR would not cause the issue.

BTW, in my test, I'm using esp32c3-devkit, is'a single core chip.

masayuki2009 · 2023-02-24T01:47:30Z

BTW, in my test, I'm using esp32c3-devkit, is'a single core chip.

I've just confirmed that non-SMP can reproduce the issue too.

--- a/boards/xtensa/esp32/esp32-devkitc/configs/wapi_smp/defconfig
+++ b/boards/xtensa/esp32/esp32-devkitc/configs/wapi_smp/defconfig
@@ -67,7 +67,6 @@ CONFIG_NET_ICMP=y
 CONFIG_NET_ICMP_SOCKET=y
 CONFIG_NET_STATISTICS=y
 CONFIG_NET_TCP=y
-CONFIG_NET_TCP_WRITE_BUFFERS=y
 CONFIG_NET_UDP=y
 CONFIG_NFS=y
 CONFIG_NSH_ARCHINIT=y
@@ -89,8 +88,6 @@ CONFIG_RTC_DRIVER=y
 CONFIG_RTC_NALARMS=2
 CONFIG_SCHED_LPWORK=y
 CONFIG_SIG_DEFAULT=y
-CONFIG_SMP=y
-CONFIG_SMP_NCPUS=2
 CONFIG_SPI=y
 CONFIG_SPIFFS_NAME_MAX=48
 CONFIG_STACK_COLORATION=y

no1wudi · 2023-02-24T02:26:27Z

@masayuki2009 The root case is that write ops in telnet driver is nearly unbuffered ,so there are many 1 byte write to socket without stdio's buffer , I'll fix it soon.

continue the change from #1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

continue the change from apache#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

The audio tone generator stopped working with the 'echo' command since apache/nuttx-apps#1559 Before that PR: nsh> echo "t120o1l16b9n0baan0bn0bn0baaan0b9n0baan0b" > /dev/tone0 tone_write: Received 41 bytes nsh> After that PR: nsh> echo "t120o1l16b9n0baan0bn0bn0baaan0b9n0baan0b" > /dev/tone0 tone_write: Received 40 bytes tone_write: Received 1 bytes nsh> Unfortunately the Audio Tone was not block new write attempts even when it was already playing a melody. This commit fix it and avoids the issue caused by that PR. Signed-off-by: Alan C. Assis <acassis@gmail.com>

This commit fixes the previous behavior where an echo with a single string and its default new line is send as single write(). This issue came from: #1559 Signed-off-by: Alan C. Assis <acassis@gmail.com>

The audio tone generator stopped working with the 'echo' command since apache/nuttx-apps#1559 Before that PR: nsh> echo "t120o1l16b9n0baan0bn0bn0baaan0b9n0baan0b" > /dev/tone0 tone_write: Received 41 bytes nsh> After that PR: nsh> echo "t120o1l16b9n0baan0bn0bn0baaan0b9n0baan0b" > /dev/tone0 tone_write: Received 40 bytes tone_write: Received 1 bytes nsh> Unfortunately the Audio Tone was not block new write attempts even when it was already playing a melody. This commit fix it and avoids the issue caused by that PR. Signed-off-by: Alan C. Assis <acassis@gmail.com>

continue the change from apache/nuttx-apps#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

This commit fixes the previous behavior where an echo with a single string and its default new line is send as single write(). This issue came from: #1559 Signed-off-by: Alan C. Assis <acassis@gmail.com>

no1wudi force-pushed the master branch 3 times, most recently from 3429eaa to 442418a Compare February 10, 2023 14:56

xiaoxiang781216 mentioned this pull request Feb 10, 2023

Make more fs API available when CONFIG_DISABLE_MOUNTPOINT isn't enabled apache/nuttx#8498

Merged

xiaoxiang781216 reviewed Feb 10, 2023

View reviewed changes

Comment thread nshlib/nsh.h Outdated

Comment thread nshlib/nsh_altconsole.c Outdated

Comment thread nshlib/nsh_altconsole.c Outdated

no1wudi force-pushed the master branch from 442418a to 0142693 Compare February 11, 2023 00:42

xiaoxiang781216 reviewed Feb 11, 2023

View reviewed changes

Comment thread nshlib/nsh_altconsole.c Outdated

xiaoxiang781216 reviewed Feb 11, 2023

View reviewed changes

Comment thread nshlib/nsh_altconsole.c Outdated

no1wudi force-pushed the master branch 2 times, most recently from b42d4c9 to 78b6b8b Compare February 11, 2023 14:48

xiaoxiang781216 reviewed Feb 11, 2023

View reviewed changes

no1wudi force-pushed the master branch 7 times, most recently from a76f7e6 to 28ddefe Compare February 13, 2023 12:15

xiaoxiang781216 reviewed Feb 13, 2023

View reviewed changes

Comment thread system/readline/readline_common.c Outdated

no1wudi force-pushed the master branch from 28ddefe to 2bc13b0 Compare February 13, 2023 14:34

xiaoxiang781216 reviewed Feb 13, 2023

View reviewed changes

Comment thread nshlib/nsh_console.c Outdated

no1wudi force-pushed the master branch 2 times, most recently from e3cd73e to 6b8ac4d Compare February 16, 2023 05:52

no1wudi force-pushed the master branch 3 times, most recently from 4396ea7 to 3fab20d Compare February 20, 2023 08:54

no1wudi closed this Feb 21, 2023

xiaoxiang781216 added a commit to xiaoxiang781216/nuttx-apps that referenced this pull request Feb 23, 2023

nshlib: Remove the remaining CONFIG_FILE_STREAM dependence

449ade0

continue the change from apache#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

xiaoxiang781216 added a commit to xiaoxiang781216/nuttx-apps that referenced this pull request Feb 23, 2023

nshlib: Remove the remaining CONFIG_FILE_STREAM dependence

d9fe860

continue the change from apache#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

xiaoxiang781216 added a commit to xiaoxiang781216/nuttx-apps that referenced this pull request Feb 23, 2023

nshlib: Remove the remaining CONFIG_FILE_STREAM dependence

8386806

continue the change from apache#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

xiaoxiang781216 added a commit to xiaoxiang781216/nuttx-apps that referenced this pull request Feb 23, 2023

nshlib: Remove the remaining CONFIG_FILE_STREAM dependence

7a2857f

continue the change from apache#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

xiaoxiang781216 added a commit to xiaoxiang781216/nuttx-apps that referenced this pull request Feb 23, 2023

nshlib: Remove the remaining CONFIG_FILE_STREAM dependence

f9a7000

continue the change from apache#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

xiaoxiang781216 added a commit to xiaoxiang781216/nuttx-apps that referenced this pull request Feb 23, 2023

nshlib: Remove the remaining CONFIG_FILE_STREAM dependence

0d16dd4

continue the change from apache#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

no1wudi mentioned this pull request Feb 24, 2023

stdio: Implement simple buffered out stream for vdprintf apache/nuttx#8641

Merged

GUIDINGLI pushed a commit that referenced this pull request Feb 24, 2023

nshlib: Remove the remaining CONFIG_FILE_STREAM dependence

359f66a

continue the change from #1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

anchao pushed a commit to anchao/nuttx-apps that referenced this pull request Mar 6, 2023

nshlib: Remove the remaining CONFIG_FILE_STREAM dependence

b7012d6

continue the change from apache#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

This was referenced Jun 26, 2026

drivers/audio: Fix audio tone generator apache/nuttx#19225

Merged

nsh/echo: Fix echo command to keep original behavior adding a '\n' as a single write() #3565

Merged

jerpelea mentioned this pull request Jul 2, 2026

{bp-19225} drivers/audio: Fix audio tone generator apache/nuttx#19262

Merged

crafcat7 pushed a commit to crafcat7/vela-nuttx-apps that referenced this pull request Jul 14, 2026

nshlib: Remove the remaining CONFIG_FILE_STREAM dependence

22f3f9b

continue the change from apache/nuttx-apps#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

crafcat7 pushed a commit to crafcat7/vela-nuttx-apps that referenced this pull request Jul 14, 2026

nshlib: Remove the remaining CONFIG_FILE_STREAM dependence

b63d197

continue the change from apache/nuttx-apps#1559 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

jerpelea mentioned this pull request Aug 4, 2026

{bp-3565} nsh/echo: Fix echo previous behavior, single write with '\n' #3699

Merged

Uh oh!

Conversation

no1wudi commented Feb 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Impact

Testing

Uh oh!

xiaoxiang781216 commented Feb 10, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

no1wudi commented Feb 16, 2023

Uh oh!

no1wudi commented Feb 23, 2023

Uh oh!

no1wudi commented Feb 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

masayuki2009 commented Feb 23, 2023

Uh oh!

masayuki2009 commented Feb 23, 2023

Uh oh!

masayuki2009 commented Feb 23, 2023

Uh oh!

masayuki2009 commented Feb 23, 2023

Uh oh!

masayuki2009 commented Feb 24, 2023

Uh oh!

no1wudi commented Feb 24, 2023

Uh oh!

no1wudi commented Feb 24, 2023

Uh oh!

masayuki2009 commented Feb 24, 2023

Uh oh!

no1wudi commented Feb 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

no1wudi commented Feb 10, 2023 •

edited

Loading

no1wudi commented Feb 23, 2023 •

edited

Loading