Skip to content

Fix no-std builds for MacOS and BSDs - #647

Merged
sunfishcode merged 2 commits into
bytecodealliance:mainfrom
niluxv:fix-nostd
Apr 30, 2023
Merged

Fix no-std builds for MacOS and BSDs#647
sunfishcode merged 2 commits into
bytecodealliance:mainfrom
niluxv:fix-nostd

Conversation

@niluxv

@niluxv niluxv commented Apr 30, 2023

Copy link
Copy Markdown
Contributor

Now to my knowledge all targets except windows compile fine for no-std again.

@niluxv

niluxv commented Apr 30, 2023

Copy link
Copy Markdown
Contributor Author

That CI failure seems unrelated to my changes:

 error: variable does not need to be mutable
   --> src/net/send_recv/msg.rs:171:13
    |
171 |         let mut last_header = leap!(messages::Messages::new(buffer).last());
    |             ----^^^^^^^^^^^
    |             |
    |             help: remove this `mut`
    |
    = note: `-D unused-mut` implied by `-D warnings`

I guess I can fix it though (last_header doesn't need to be mutable, since it is an &mut reference, and only the pointed-to place needs to be mutated).

@niluxv niluxv closed this Apr 30, 2023
@niluxv niluxv reopened this Apr 30, 2023
@sunfishcode

Copy link
Copy Markdown
Member

Thanks!

@sunfishcode
sunfishcode merged commit 7f4c3fe into bytecodealliance:main Apr 30, 2023
@sunfishcode

Copy link
Copy Markdown
Member

This is now released in rustix 0.37.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants