Run tests on Windows with PHPUnit - #31
Merged
Merged
Conversation
clue
added
bug
clue
approved these changes
Jul 27, 2021
clue
left a comment
clue
left a comment
Owner
There was a problem hiding this comment.
@SimonFrings Thanks for looking into this, changes LGTM! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a follow up for #25. Thanks to @HLeithner for investing time into finding and solving the problem 👍.
The only thing I had to do is to add Windows to the test matrix inside the
ci.ymlto run all tests with PHPUnit on Windows.I didn't test any of the webserver with Windwos yet, this is something for another pull request. If there is any need for this I am happy to take a look.
Resolves and Closes #25.