fix(plugin-basic-ui): calculate app screen height correctly with safearea - #492
Merged
orionmiz merged 1 commit intoAug 1, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 77814aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
XiNiHa
force-pushed
the
fix/appscreen-height-safearea
branch
from
July 31, 2024 05:49
a177267 to
77814aa
Compare
tonyfromundefined
self-requested a review
July 31, 2024 10:03
orionmiz
self-requested a review
August 1, 2024 02:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced by #479 which results in height larger than the actual screen when the device has safe-area-inset-top value other than 0.