fix(tui): restyle history-search input on live theme change - #3786
Merged
Conversation
The ThemeChangedMsg handler only restyled the main textarea, leaving the history-search input with the styles captured at construction time. It now reapplies the shared searchInputStyles() to searchInput as well, so both inputs follow the active theme after a live theme switch. Fixes #3784
aheritier
added
area/tui
trungutt
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3784.
The TUI editor did not fully apply live theme changes to its
history-search input. On
messages.ThemeChangedMsgthe editorreapplied the current theme to its main textarea but left the internal
searchInputstyled with the theme that was active when the editor wasconstructed, producing visibly stale styling (e.g. dark-theme gray text
after switching to the light
catppuccin-lattetheme).Changes
searchInputStyles()helper that builds the customizedsearch-input styles (
DialogInputStyle+ muted text/placeholder),shared by
Newand theThemeChangedMsghandler so both stay insync with the active theme.
messages.ThemeChangedMsghandler now reapplies styles tosearchInputin addition to the main textarea.ThemeChangedMsgupdates the history-search input's colors (focused/blurred text and
placeholder) as well as the main textarea. Verified to fail against
the pre-fix handler and pass with the fix.
Validation
task build— passestask test— passestask lint— 0 issuesDownstream context
Found while fixing a WCAG contrast issue in Docker Sandboxes' Gordon
assistant (docker/sandboxes#4528).