fix(openai): deduplicate Copilot response text - #3846
Merged
Conversation
dgageot
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output_indexwhen eventitem_idvalues differIssue expectations
github-copilotare emitted onceoutput_indexresponse.output_item.doneremains a fallback when no content was emittedoutput_indexReproduction
Before the fix, the regression stream produced:
After the fix, it produces:
Validation
go test ./pkg/model/provider/openai -run TestResponseStream_CopilotUnstableItemIDsOutputTextNotDuplicated -count=20go test -race ./pkg/model/provider/openai -run TestResponseStream_CopilotUnstableItemIDsOutputTextNotDuplicated -count=1go test ./pkg/model/provider/openai -count=1env -u HTTP_PROXY -u HTTPS_PROXY -u ALL_PROXY -u http_proxy -u https_proxy -u all_proxy task testtask --force linttask buildLive verification against the affected
gpt-5.6-*models was unavailable because the models are disabled for the available Copilot token and returnmodel_not_supported. The regression test replays the observed Copilot event shape deterministically.Fixes #3839