fix(models): unify gateway model discovery - #3847
Merged
Merged
Conversation
dgageot
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unify models-gateway discovery semantics between
docker agent modelsand the interactive/modelpicker.A non-empty
/v1/modelsresponse is now the source of truth for gateway-routed models. Discovery failures fall back independently to directly usable providers, aliases, custom providers, and the catalog without requiring a Docker Desktop token for generic gateways.Expected behavior
docker agent modelscalls<gateway>/v1/modelsthroughmodelsgateway.ListModelsprovider/modelIDs are preserved; no provider allow-list is used--providerfilters normalized gateway results--all, default marking, aliases, env credentials, env files, and user-config providers remain supportedImplementation
pkg/modelsgateway.pkg/configwithout changingconfig.AvailableProvidersor model auto-selection.Tests
Hermetic coverage includes:
--providerfiltering;Validation completed:
task buildtask linttask testNo model generation or real provider API calls are used by the added tests.
Scope
docker agent models.bypass_models_gatewayremain runtime-only concerns.