remove_PRECISE_I64_MATH - #7935
Merged
Merged
Conversation
juj
force-pushed
the
remove_PRECISE_I64_MATH
branch
2 times, most recently
from
January 27, 2019 17:14
f46e740 to
f49ce9a
Compare
kripken
approved these changes
Jan 27, 2019
| t = time.time() | ||
|
|
||
| # Settings changes | ||
| i64_funcs = ['i64Add', 'i64Subtract', '__muldi3', '__divdi3', '__udivdi3', '__remdi3', '__uremdi3'] |
Member
There was a problem hiding this comment.
I worry some of these might be used by asm.js code, but if tests pass then good.
| var signed = next == {{{ charCode('d') }}} || next == {{{ charCode('i') }}}; | ||
| argSize = argSize || 4; | ||
| currArg = getNextArg('i' + (argSize * 8)); | ||
| #if PRECISE_I64_MATH |
Member
There was a problem hiding this comment.
I think we should do the opposite in this file - assume it is always 1, so printing i64s work.
Member
There was a problem hiding this comment.
(the default was 1, so this would keep things the same as before)
Collaborator
Author
There was a problem hiding this comment.
I started like that, but the code is testing if (typeof i64Math === 'object') which is always false, so I removed this altogether because that condition will never be true. Since src/long.js is never emitted to the code, we do not have a i64Math object ever being generated, so the condition there never passes.
…ike PRECISE_I64_MATH has not actually done anything for a long time.
juj
force-pushed
the
remove_PRECISE_I64_MATH
branch
from
January 27, 2019 22:34
f49ce9a to
f6da8ba
Compare
DrJosh9000
added a commit
to DrJosh9000/pce
that referenced
this pull request
Mar 1, 2019
Hi! I'm a massive fan of your work. Thanks so much for making Macintosh emulation in the browser happen. I got the following errors in config.log when attempting to `./pcejs_build build macplus`: shared:ERROR: Invalid command line option -s BINARYEN_METHOD=native-wasm,asmjs: Starting from Emscripten 1.38.23, Emscripten now always builds either to Wasm (-s WASM=1 - default), or to asm.js (-s WASM=0), other methods are not supported (https:#github.com/emscripten-core/emscripten/pull/7836) shared:ERROR: Invalid command line option -s PRECISE_I64_MATH=0: Starting from Emscripten 1.38.26, PRECISE_I64_MATH is always enabled (https:#github.com/emscripten-core/emscripten/pull/7935) This patch makes it build, and I get some output in dist/, but I haven't checked if the output works.
th-otto
pushed a commit
to th-otto/pce
that referenced
this pull request
Nov 25, 2019
Hi! I'm a massive fan of your work. Thanks so much for making Macintosh emulation in the browser happen. I got the following errors in config.log when attempting to `./pcejs_build build macplus`: shared:ERROR: Invalid command line option -s BINARYEN_METHOD=native-wasm,asmjs: Starting from Emscripten 1.38.23, Emscripten now always builds either to Wasm (-s WASM=1 - default), or to asm.js (-s WASM=0), other methods are not supported (https:#github.com/emscripten-core/emscripten/pull/7836) shared:ERROR: Invalid command line option -s PRECISE_I64_MATH=0: Starting from Emscripten 1.38.26, PRECISE_I64_MATH is always enabled (https:#github.com/emscripten-core/emscripten/pull/7935) This patch makes it build, and I get some output in dist/, but I haven't checked if the output works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove PRECISE_I64_MATH option and delete unused src/long.js. Looks like PRECISE_I64_MATH=0 nor PRECISE_I64_MATH=2 have not actually done anything for a long time.