Skip to content

[Feature]: add dates comparing - #18

Merged
justin-schroeder merged 6 commits into
formkit:mainfrom
hrynevychroman:feat/dates-comparing
Feb 23, 2024
Merged

[Feature]: add dates comparing#18
justin-schroeder merged 6 commits into
formkit:mainfrom
hrynevychroman:feat/dates-comparing

Conversation

@hrynevychroman

Copy link
Copy Markdown
Contributor

This PR fixes #17

@vercel

vercel Bot commented Feb 22, 2024

Copy link
Copy Markdown

@romanhrynevych is attempting to deploy a commit to the Formkit Team on Vercel.

A member of the Team first needs to authorize it.

@justin-schroeder

Copy link
Copy Markdown
Member

Thanks again for the effort here @romanhrynevych. Everything looks in order here. although I’m not sure I fully understand the utility of these kinds of functions. Is it just syntactic sugar?

@vercel

vercel Bot commented Feb 23, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tempo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 7:07pm

@justin-schroeder justin-schroeder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romanhrynevych requested 2 itty bitty changes, then I’ll merge this.

Comment thread docs/components/content/CommonHelpers.vue Outdated
Comment thread docs/pages/index.vue Outdated
@hrynevychroman

Copy link
Copy Markdown
Contributor Author

@justin-schroeder everything done, review it please ❤️

image

@justin-schroeder justin-schroeder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more small things @romanhrynevych and we’ll be good to go.

Comment thread docs/pages/index.vue Outdated
Comment thread src/isEqual.ts Outdated
Comment thread src/isBefore.ts Outdated
hrynevychroman and others added 3 commits February 23, 2024 20:59
Co-authored-by: Justin Schroeder <justin@formkit.com>
Co-authored-by: Justin Schroeder <justin@formkit.com>
Co-authored-by: Justin Schroeder <justin@formkit.com>
@hrynevychroman

Copy link
Copy Markdown
Contributor Author

@justin-schroeder accept all your changes, seems good to me 🙂

@justin-schroeder
justin-schroeder merged commit 34d8c27 into formkit:main Feb 23, 2024
@hrynevychroman
hrynevychroman deleted the feat/dates-comparing branch February 23, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] Dates comparing

2 participants