Skip to content

add section about referencing branches other than master - #249

Merged
forki merged 2 commits into
fsprojects:masterfrom
mexx:doc-github-dependencies
Oct 12, 2014
Merged

add section about referencing branches other than master#249
forki merged 2 commits into
fsprojects:masterfrom
mexx:doc-github-dependencies

Conversation

@mexx

@mexx mexx commented Oct 12, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@forki

forki commented Oct 12, 2014

Copy link
Copy Markdown
Member

that's actually not supported. since it would not look up the hash and won't pin in lock file.
But I'd love to see this happen

@ilkerde

ilkerde commented Oct 12, 2014

Copy link
Copy Markdown

👍 Would be a great supportive thing to support floating sources. Imagine a source constraint a la FsUnit.fs (:master)...

@forki

forki commented Oct 12, 2014

Copy link
Copy Markdown
Member

actually I meant exactly the opposite.
At the moment it would be floating on the branch and that defeats the whole idea of the lockfile.

@mexx

mexx commented Oct 12, 2014

Copy link
Copy Markdown
Contributor Author

So you mean it's actually a bug in there, it's not locked currently, did I got you right?

@forki

forki commented Oct 12, 2014

Copy link
Copy Markdown
Member

Yes. It's a bug. Pinning only works on master.
On Oct 12, 2014 12:09 PM, "Max Malook" notifications@github.com wrote:

So you mean it's actually a bug in there, it's not locked currently, did I
got you right?


Reply to this email directly or view it on GitHub
#249 (comment).

@ilkerde

ilkerde commented Oct 12, 2014

Copy link
Copy Markdown

OMG.

@forki

forki commented Oct 12, 2014

Copy link
Copy Markdown
Member

OMG? What do you mean?
On Oct 12, 2014 12:35 PM, "ilkerde" notifications@github.com wrote:

OMG.


Reply to this email directly or view it on GitHub
#249 (comment).

@ilkerde

ilkerde commented Oct 12, 2014

Copy link
Copy Markdown

OMG = I didn't knew that we had this bug. I'm glad you have total control over this. I can hardly follow the state of development. Maybe that's why I missed this.

@forki

forki commented Oct 12, 2014

Copy link
Copy Markdown
Member

It's not really a bug. It's just not implemented.
On Oct 12, 2014 1:02 PM, "ilkerde" notifications@github.com wrote:

OMG = I didn't knew that we had this bug. I'm glad you have total control
over this. I can hardly follow the state of development. Maybe that's why I
missed this.


Reply to this email directly or view it on GitHub
#249 (comment).

@mexx
mexx force-pushed the doc-github-dependencies branch from 6431f18 to c92cd76 Compare October 12, 2014 11:06
@mexx

mexx commented Oct 12, 2014

Copy link
Copy Markdown
Contributor Author

I've added the implementation for this.
It's working for me now.

@forki

forki commented Oct 12, 2014

Copy link
Copy Markdown
Member

So we can pin all branches?
On Oct 12, 2014 1:08 PM, "Max Malook" notifications@github.com wrote:

I've added the implementation for this.
It's working for me now.


Reply to this email directly or view it on GitHub
#249 (comment).

@mexx

mexx commented Oct 12, 2014

Copy link
Copy Markdown
Contributor Author

Yes with this code change we can.

@forki

forki commented Oct 12, 2014

Copy link
Copy Markdown
Member

Ha. Didn't see this trick. Kudos
On Oct 12, 2014 1:27 PM, "Max Malook" notifications@github.com wrote:

Yes with this code change we can.


Reply to this email directly or view it on GitHub
#249 (comment).

forki added a commit that referenced this pull request Oct 12, 2014
add section about referencing branches other than master
@forki
forki merged commit 46db1f0 into fsprojects:master Oct 12, 2014
@mexx
mexx deleted the doc-github-dependencies branch October 12, 2014 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants