Skip to content

add net11 to framework handling - references #266 - #269

Merged
forki merged 3 commits into
fsprojects:masterfrom
theimowski:handle_net11_framework
Oct 21, 2014
Merged

add net11 to framework handling - references #266#269
forki merged 3 commits into
fsprojects:masterfrom
theimowski:handle_net11_framework

Conversation

@theimowski

Copy link
Copy Markdown
Member

references or even fixes #266

Comment thread src/Paket.Core/FrameworkHandling.fs Outdated

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 1.0, 1.1, 2.0 result in AllVersions?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is old stuff and should be replaced. "All" is not needed any more

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you replace it with specific versions?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@theimowski

Copy link
Copy Markdown
Member Author

I also removed the FrameworkProfile DU for simplification, and added V4_Client case to FrameworkVersion
please have a look if sth won't explode because of that

forki added a commit that referenced this pull request Oct 21, 2014
add net11 to framework handling - references #266
@forki
forki merged commit cd6eeb8 into fsprojects:master Oct 21, 2014
@theimowski
theimowski deleted the handle_net11_framework branch October 21, 2014 07:20
@forki

forki commented Oct 21, 2014

Copy link
Copy Markdown
Member

very cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

convert-from-nuget doesn't properly update some project reference hint paths

2 participants