Conversation
matthid
left a comment
matthid
left a comment
There was a problem hiding this comment.
Schaut gut aus. ich frage mich ob man den Filter auch in extractPlatforms reinziehen kann. Aber vermutlich eher nicht weil sonst Gruppen als Fallback Gruppen erkannt werden
| (cachedObject.Version <> version.Normalize()) | ||
| then | ||
| traceVerbose (sprintf "Invalidating Cache '%s:%s' <> '%s:%s'" cachedObject.PackageName cachedObject.Version packageName.Name (version.Normalize())) | ||
| if verbose then |
There was a problem hiding this comment.
macht den check nicht auch traceVerbose schon?
There was a problem hiding this comment.
yes, but the right side (sprintf ...) would be evaluated even if verbose is false.
This was serious perf problem in the past
There was a problem hiding this comment.
Should we remove traceVerbose in that case ?
|
if we move it into extractPlatforms then we get the annoying warnings that dnxcore is not real moniker |
|
I did that a while ago, but I'm not remembering why it didn't work fully
Am 02.10.2017 12:21 schrieb "Matthias Dittrich" <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In src/Paket.Core/Dependencies/NuGetCache.fs
<#2813 (comment)>:
> @@ -176,7 +179,8 @@ let tryGetDetailsFromCache force nugetURL (packageName:PackageName) (version:Sem
if (PackageName cachedObject.PackageName <> packageName) ||
(cachedObject.Version <> version.Normalize())
then
- traceVerbose (sprintf "Invalidating Cache '%s:%s' <> '%s:%s'" cachedObject.PackageName cachedObject.Version packageName.Name (version.Normalize()))
+ if verbose then
Should we remove traceVerbose in that case ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2813 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADgNNSMomYRhlovl7AK_bc2NKJzWgzTks5soLkxgaJpZM4PqYSx>
.
|
|
Tests need to be adapted. The current failure looks a bit suspicious, but it might be that the error message is just incomplete and everything is fine. |
|
Working on the tests. Will come later today
Am 02.10.2017 12:24 schrieb "Matthias Dittrich" <notifications@github.com>:
… Tests need to be adapted. The current failure looks a bit suspicious, but
it might be that the error message is just incomplete and everything is
fine.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2813 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNIDnIHHHcbVAJr7tdwS9HmHcN4z9ks5soLnYgaJpZM4PqYSx>
.
|
2 participants
fixes #2810