Paket pack with --template fails trying to load the dependencies of templates who should be ignored instead - #3363
Merged
forki merged 7 commits intoSep 18, 2018
Conversation
…ouldn't consider others template files. in the regression test, the `paket pack` failed because tried to load `PaketBug2`template file, who isnt ready (a file required doesn't exists)
otherwise some templates may be validated (failing if required files doesnt exists), when are not needed
Collaborator
Author
Member
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When specified the
--templateargument, thepaket packsearch also for project references (finding all thepaket.templatefiles in same directory of project files)Doing so, paket try to load and validate the found
paket.templatefiles.But these template files may be not needed (like when
--templateis specified), and some may fail to load (for example afilesrequired doesnt exists, because was not built)This PR refactor the code to parse the found paket.template files, and just load these when are needed (if are not needed, are not validated, just considered for metadata)