Skip to content

Fix issue 3381 - generate load script - #3385

Merged
forki merged 5 commits into
fsprojects:masterfrom
andre-correia:andre-correia/issue-3381-generate-load-script
Oct 15, 2018
Merged

Fix issue 3381 - generate load script#3385
forki merged 5 commits into
fsprojects:masterfrom
andre-correia:andre-correia/issue-3381-generate-load-script

Conversation

@andre-correia

@andre-correia andre-correia commented Oct 13, 2018

Copy link
Copy Markdown

@forki

forki commented Oct 15, 2018

Copy link
Copy Markdown
Member

what's the status?

@andre-correia

Copy link
Copy Markdown
Author

The integration test scenario that I've created is passing now but there are a few other tests that are now failing. I am checking why.

@andre-correia

Copy link
Copy Markdown
Author

@forki I noticed that some of the tests have the attribute Flaky so I guess those are normal to fail under certain conditions like a different MSBuild version for example, right?

@andre-correia

Copy link
Copy Markdown
Author

@forki I've checked all the tests and none of them seems to be due to my changes. Can you please confirm?

@andre-correia andre-correia changed the title [WIP] Fix issue 3381 - generate load script Fix issue 3381 - generate load script Oct 15, 2018
@matthid

matthid commented Oct 15, 2018

Copy link
Copy Markdown
Member

@andre-correia Please feel free to fix them if you know how ;)

@matthid

matthid commented Oct 15, 2018

Copy link
Copy Markdown
Member

But yeah all PRs are red but AppVeyor is green in master?

@enricosada

Copy link
Copy Markdown
Collaborator

I checked, so

travis

the same travis tests were already red on master ( https://travis-ci.org/fsprojects/Paket/jobs/435977159 )

appveyor

appeveyor tests fails is unrelated i think ( ref https://ci.appveyor.com/project/paket/paket/builds/19485318/job/hs86ojf27cyw1a6n/tests )

image

I'll try rerun the same, maybe is flacky and will go green

@forki
forki merged commit 51ff1b1 into fsprojects:master Oct 15, 2018
@andre-correia
andre-correia deleted the andre-correia/issue-3381-generate-load-script branch October 15, 2018 14:05
@andre-correia

Copy link
Copy Markdown
Author

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants