new option to control interproject references version constraint

[lexarchik]

#2520
New cli parameter and templatefile option interproject-references.
Possible values are min, fix, keep-major, keep-minor, keep-patch.

This makes --pin-project-references obsolete.

[agross]

Thank you! I commented on some spelling mistakes. Please correct them.

[lexarchik]

Thank you for review :)
Just made fixes.

[agross]

@lexarchik Thank you. I read a second pass and have made some more comments. The new docs will shine ;-)

[lexarchik]

@agross thanks)

[forki]

it doesn't build locally for me.

[lexarchik]

@forki fixed.
I forgot about Paket.preview3.sln

[lexarchik]

@forki Have you reviewed this PR? Are there any problems with it?

[forki]

thanks for this!

[BlythMeister]

@lexarchik @forki this is a breaking change. If you were using interproject-references you are now forced to include the new option.
Was this intentional? - is there no sensible default?

[lexarchik]

why is it breaking change?
how including new option is forced?

default value for this option is "min"

[BlythMeister]

I had the option, without anything after (which was ok for a version or 2)
Now it says you have to pass the type e.g. min

[lexarchik]

its strange. interproject-references is completly new option. it was added in this pr.
you got error about cli parameter or about option in templatefile?

[BlythMeister]

I got an error saying it expected a parameter after interproject-references

[BlythMeister]

Whereas, I have another option after it...maybe it's just the way the options are parsed...

[lexarchik]

can you make a little repro solution that work with older paket version and fail with newer?

[BlythMeister]

Sure, here is the args I pass, copied from my Fake script.
‘‘‘
  let args = sprintf "pack --minimum-from-lock-file --interproject-references --pin-project-references %s" outputDir
‘‘‘
By adding 'min' after the interproject-references paket works.
This was working, and then a recent update caused this to break.

I updated the command to add 'min' and remove the pin-project-references and it started working again.

[lexarchik]

and with what version of paket did this work without "min"?

[BlythMeister]

Hmmm...maybe it didn't...