Skip to content

Integrate BindingRedirects into Paket install process. - #383

Merged
forki merged 1 commit into
fsprojects:masterfrom
isaacabraham:master
Nov 23, 2014
Merged

Integrate BindingRedirects into Paket install process.#383
forki merged 1 commit into
fsprojects:masterfrom
isaacabraham:master

Conversation

@isaacabraham

Copy link
Copy Markdown
Contributor

This PR integrates the code for #245 into the main install process. There are a few fixes I made at the same time.

Issues: -

  • Does not support removal of BRs when a dependency is removed.
  • Is greedy i.e. will simply put a BR for every strong-named assembly even if not necessarily required.

Could use some feedback on this as to where it should go from here (and whether I've integrated it in the correct place).

Correct some issues with BindingRedirects e.g. namespaces and neutral culture.
@forki

forki commented Nov 23, 2014

Copy link
Copy Markdown
Member

how can I test this?

forki added a commit that referenced this pull request Nov 23, 2014
Integrate BindingRedirects into Paket install process.
@forki
forki merged commit 5382721 into fsprojects:master Nov 23, 2014
@isaacabraham

Copy link
Copy Markdown
Contributor Author

Just run a Paket install and check the .config files afterwards. There are unit tests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants