Skip to content

Selective update should only update dependent packages - #410

Merged
forki merged 3 commits into
masterfrom
update
Dec 1, 2014
Merged

Selective update should only update dependent packages#410
forki merged 3 commits into
masterfrom
update

Conversation

@forki

@forki forki commented Nov 30, 2014

Copy link
Copy Markdown
Member

@agross showed in #400 that we fix to few packages in selective updates.

Before: we fixed all direct dependencies from the paket.dependencies file and ignore indirect dependencies
Now: we fix all packages that are not dependencies of the package in question

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forki You could refactor it further to use an accumulator parameter, than we can call
addPackage package (HashSet<_>()) and remove this usedPackages.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same logic is here - maybe could be reused?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please send PR

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

@mexx

mexx commented Nov 30, 2014

Copy link
Copy Markdown
Contributor

besides of further functional refactoring, looks good 👍

forki added a commit that referenced this pull request Dec 1, 2014
Selective update should only update dependent packages
@forki
forki merged commit 57d6303 into master Dec 1, 2014
@matthid
matthid deleted the update branch May 6, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants