Skip to content

Http links - #428

Merged
forki merged 2 commits into
masterfrom
HTTPLinks
Dec 5, 2014
Merged

Http links#428
forki merged 2 commits into
masterfrom
HTTPLinks

Conversation

@forki

@forki forki commented Dec 5, 2014

Copy link
Copy Markdown
Member

The URL of the dependencies file for HTTP links is wrong see https://github.com/fsprojects/Paket/compare/HTTPLinks?expand=1#diff-f49621e896c9b89745f9d4aa9e06cb6fR48

The result is that we currently download the HTTP resource twice. This makes things very slow - as seen in #298

/cc @sergey-tihon

@sergey-tihon

Copy link
Copy Markdown
Member

Wow @forki !!! You are so fast...

@forki

forki commented Dec 5, 2014

Copy link
Copy Markdown
Member Author

is that a "ship it"?

@sergey-tihon

Copy link
Copy Markdown
Member

Yes, it is faster now and download files only once, but it makes very strange calls to the server.
image

@forki

forki commented Dec 5, 2014

Copy link
Copy Markdown
Member Author

that's actually expected. It tries to locate a (in this case not existing) paket.dependencies file. This allows you to specify further dependencies. see http://fsprojects.github.io/Paket/github-dependencies.html#Remote-dependencies

@sergey-tihon

Copy link
Copy Markdown
Member

It is a bit strange for me... I thought about something like caching calls during the paket process lifetime... But if it is an expected behavior... no other complaints - "ship it"!

forki added a commit that referenced this pull request Dec 5, 2014
@forki
forki merged commit 152ab87 into master Dec 5, 2014
@forki
forki deleted the HTTPLinks branch December 5, 2014 15:18
@forki

forki commented Dec 5, 2014

Copy link
Copy Markdown
Member Author

released in 0.17.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants