Skip to content

Referencing of multiple files from same repository directory - #445

Merged
forki merged 2 commits into
masterfrom
MultipleGH
Dec 9, 2014
Merged

Referencing of multiple files from same repository directory #445
forki merged 2 commits into
masterfrom
MultipleGH

Conversation

@forki

@forki forki commented Dec 9, 2014

Copy link
Copy Markdown
Member

Should allow to unbundle FSharp.Data from Deedle

/cc @tpetricek, @isaacabraham, @mexx

forki added a commit that referenced this pull request Dec 9, 2014
Referencing of multiple files from same repository directory
@forki
forki merged commit b5ea05a into master Dec 9, 2014
@forki
forki deleted the MultipleGH branch December 9, 2014 11:48

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work as CleanDir removes the directory with all the already downloaded files.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahj this would explain #442

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's the cause of it

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about e7e3a43 ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, but if someone reference multiple files from different branches, so version would differ and the behavior is not predictable and we would still get access errors.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That's true I don't have a good solution right now. Maybe you see a better way

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided better handling with #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants