Skip to content

Don't add Nuget package twice to ReferencesFile - fixes #454 - #460

Merged
forki merged 1 commit into
masterfrom
install
Dec 20, 2014
Merged

Don't add Nuget package twice to ReferencesFile - fixes #454#460
forki merged 1 commit into
masterfrom
install

Conversation

@forki

@forki forki commented Dec 20, 2014

Copy link
Copy Markdown
Member

No description provided.

forki added a commit that referenced this pull request Dec 20, 2014
Don't add Nuget package twice to ReferencesFile - fixes #454
@forki
forki merged commit d9dbf4d into master Dec 20, 2014
@forki
forki deleted the install branch December 20, 2014 15:05

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packageName is not used in any way, it can be removed.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I noticed that too.
On Dec 21, 2014 1:26 AM, "Max Malook" notifications@github.com wrote:

In src/Paket.Core/AddProcess.fs
#460 (diff):

@@ -20,21 +20,12 @@ let Add(dependenciesFileName, package, version, force, hard, interactive, instal
LockFile.LoadFrom(lockFileName.FullName)

 if interactive then
  •    let (PackageName package) = package
    
  •    let (PackageName packageName) = package
    

packageName is not used in any way, it can be removed.


Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket/pull/460/files#r22144892.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants