Skip to content

Fix for #670, inter project dependencies without matching package id - #671

Merged
forki merged 2 commits into
fsprojects:masterfrom
geniussportsgroup:master
Mar 3, 2015
Merged

Fix for #670, inter project dependencies without matching package id#671
forki merged 2 commits into
fsprojects:masterfrom
geniussportsgroup:master

Conversation

@ascjones

@ascjones ascjones commented Mar 3, 2015

Copy link
Copy Markdown
Contributor

Fix for #670

Use the project name (without extension) to uniquely identify projects when determining inter project dependencies.

For this I added a new property on the ProjectFile for getting the project name without extension, so I've also used this in a couple of other places from some previous work I did.

@ascjones ascjones changed the title Fix for https://github.com/fsprojects/Paket/issues/670 Fix for #670, inter project dependencies without matching package id Mar 3, 2015
forki added a commit that referenced this pull request Mar 3, 2015
Fix for #670, inter project dependencies without matching package id
@forki
forki merged commit e53a23d into fsprojects:master Mar 3, 2015
@forki

forki commented Mar 3, 2015

Copy link
Copy Markdown
Member

thank you!

@mavnn

mavnn commented Mar 3, 2015

Copy link
Copy Markdown
Contributor

Thanks. Does it do what you want now?

@ascjones

ascjones commented Mar 3, 2015

Copy link
Copy Markdown
Contributor Author

Indeed it does, project references with corresponding paket.templates files are included as dependencies

@mavnn

mavnn commented Mar 3, 2015

Copy link
Copy Markdown
Contributor

Awesome :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants